Page MenuHomePhabricator

1.38.0-wmf.21 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease

Details

Backup Train Conductor
dancy
Release Version
1.38.0-wmf.21
Release Date
Feb 7 2022, 12:00 AM

2022 week 06 1.38-wmf.21 Changes wmf/1.38.0-wmf.21

This MediaWiki Train Deployment is scheduled for the week of Monday, February 7th:

Monday February 7thTuesday, February 8thWednesday, February 9thThursday, February 10thFriday
Backports only.Branch wmf.21 and deploy to Group 0 Wikis.Deploy wmf.21 to Group 1 Wikis.Deploy wmf.21 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.21 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.38.0-wmf.20
Next: 1.38.0-wmf.22

Event Timeline

Risky Patch! 🚂🔥
  • Change: "Add timestamp to thumbnail URLs on file pages" https://gerrit.wikimedia.org/r/c/mediawiki/core/+/756151
  • Summary: The change ensures that, when a new version of a file is uploaded, web browsers do not show a cached thumbnail of the old version, which was very confusing to users (T38380). It is risky because we do not know what tools could be relying on the exact format of thumbnail URLs (which hasn't changed in like 10 years), in particular search engines and other external re-users of content.
  • Test plan: Check that thumbnail URLs on file pages have a timestamp parameter, and that thumbnail URLs elsewhere do not.
  • Places to monitor: ?
  • Revert plan: Revert patch
  • Affected wikis: All, but especially Commons
  • IRC contact: MatmaRex, AntiComposite
  • UBN Task Projects/tags: (none, it's a volunteer patch)
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dancy.
thcipriani set the point value for this task to 5.

Noting I can provide coverage on Tuesday 2022-02-08 if needed for anything.

Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/756130
  • Summary: The pages refactors the way how mentor lists (example) are parsed. Main reason why I'm listing the change here is that an error in a similar previous change (T297827) caused a train blocker, taking a wiki down for most newcomers. New fatal errors in MentorManager, MentorProvider and subclasses will likely be relevant to the change linked above.
  • Test plan: Manually ensure Growth's mentorship features works (creating an account should trigger most of the codepaths available). Testing happened at Beta.
  • Places to monitor:
  • Revert plan: Rollback
    • While it should be possible to safely revert the patch (no changes to functionality are shipped), I recommend rolling back the train, because the patch is huge.
  • Affected wikis: testwikis, all Wikipedias and French Wiktionary
  • IRC contact: urbanecm, tgr (it's also possible to ping @growth-engineers in Slack to alert all of Growth's engineers)
  • UBN Task Projects/tags: Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-Mentorship

Change 761019 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761019

Change 761019 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761019

Mentioned in SAL (#wikimedia-operations) [2022-02-08T18:29:47Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.38.0-wmf.21 refs T300197

Mentioned in SAL (#wikimedia-operations) [2022-02-08T19:09:21Z] <jhuneidi@deploy1002> Finished scap: testwikis wikis to 1.38.0-wmf.21 refs T300197 (duration: 39m 34s)

Change 761042 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761042

Change 761042 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761042

Mentioned in SAL (#wikimedia-operations) [2022-02-08T20:17:41Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.21 refs T300197

T301324 is a new frontend error in wmf.21, affecting mobile versions of Test Wikidata and (once the train reaches group1) Wikidata. It’s an unhandled promise rejection – I’m not sure if those appear on the client errors Logstash dashboards (I can’t find the error I had on there, but I’m not sure if that’s because it’s an unhandled promise rejection, because of mobile, or due to it being on Test Wikidata). There’s no user impact apart from the error message, as far as I’m aware.

Change 761463 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761463

Change 761463 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761463

Mentioned in SAL (#wikimedia-operations) [2022-02-09T20:47:42Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.21 refs T300197

Mentioned in SAL (#wikimedia-operations) [2022-02-09T20:48:34Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.21 refs T300197 (duration: 00m 51s)

not sure whether T301433 is a blocker or not

T301433 is not yet closed but it looks like the necessary work has been done to resolve it so I'm going to deploy to all wikis now.

Change 761710 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761710

Change 761710 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.21 refs T300197

https://gerrit.wikimedia.org/r/761710

Mentioned in SAL (#wikimedia-operations) [2022-02-10T20:08:31Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.38.0-wmf.21 refs T300197