Page MenuHomePhabricator

1.38.0-wmf.23 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease

Details

Backup Train Conductor
hashar
Release Version
1.38.0-wmf.23
Release Date
Feb 21 2022, 12:00 AM

2022 week 08 1.38-wmf.23 Changes wmf/1.38.0-wmf.23

This MediaWiki Train Deployment is scheduled for the week of Monday, February 21st:

Monday February 21stTuesday, February 22ndWednesday, February 23rdThursday, February 24thFriday
Backports only.Branch wmf.23 and deploy to Group 0 Wikis.Deploy wmf.23 to Group 1 Wikis.Deploy wmf.23 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.23 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.38.0-wmf.22
Next: 1.38.0-wmf.24

Event Timeline

thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.

The train deployer this week, may get reports of issues relating to the Special:Contributions and the history page relating to the changes T298638. The issues are most likely to be related to gadget scripts. I don't think there's any circumstance where we'd need to roll back, but we may wish to patch any issues before further rollout. Please reach out to @matmarex and me, for an assessment of any issues relating to this feature.

Change 764860 had a related patch set uploaded (by Dduvall; author: Dduvall):

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/764860

Change 764860 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/764860

Mentioned in SAL (#wikimedia-operations) [2022-02-22T18:27:04Z] <dduvall@deploy1002> Started scap: testwikis wikis to 1.38.0-wmf.23 refs T300199

Mentioned in SAL (#wikimedia-operations) [2022-02-22T19:16:20Z] <dduvall@deploy1002> Finished scap: testwikis wikis to 1.38.0-wmf.23 refs T300199 (duration: 49m 17s)

Change 764885 had a related patch set uploaded (by Dduvall; author: Dduvall):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/764885

Change 764885 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/764885

Mentioned in SAL (#wikimedia-operations) [2022-02-22T20:07:25Z] <dduvall@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.23 refs T300199

The train deployer this week, may get reports of issues relating to the Special:Contributions and the history page relating to the changes T298638. The issues are most likely to be related to gadget scripts. I don't think there's any circumstance where we'd need to roll back, but we may wish to patch any issues before further rollout. Please reach out to @matmarex and me, for an assessment of any issues relating to this feature.

There is a small issue with Special:Contributions on wikis that use Flow, probably not severe enough to block the train: T302343: Date headings on Special:Contributions don't work well for Flow edits

I added T210075 as a train blocker because https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaMessages/+/763699 needs to be merged as part of this train.

Thank you @matmarex for the +2 and backport!

Change 765334 had a related patch set uploaded (by Dduvall; author: Dduvall):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/765334

Change 765334 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/765334

Mentioned in SAL (#wikimedia-operations) [2022-02-23T21:10:13Z] <dduvall@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.23 refs T300199

Mentioned in SAL (#wikimedia-operations) [2022-02-23T21:11:46Z] <dduvall@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.23 refs T300199 (duration: 01m 31s)

Hi! Not sure if this UBN bug is a train blocker, but the fix does need to be deployed to Meta (group 1) right away:
T302469: Recent message fallback change breaks fundraising banners

The issue was caused by a core change, and the patch to revert that change has been merged to master.

The issue will be fixed once the revert patch is deployed to Meta, and no further issues will be caused by deploying an unpatched version of core to group 2 wikis.

This is because banners are loaded via background calls to Meta.

Thanks!!

If it only affects one wiki, there's no point blocking the train but we should see asap about getting it deployed.

If it only affects one wiki, there's no point blocking the train but we should see asap about getting it deployed.

Yep, this works for us, thanks! Also, it happens that Fundraising banners are not live right now. (However, this does also break FR banner previews, needed to test banners that are expected to go live shortly.)

Change 765586 had a related patch set uploaded (by Dduvall; author: Dduvall):

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/765586

Change 765586 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.23 refs T300199

https://gerrit.wikimedia.org/r/765586

Mentioned in SAL (#wikimedia-operations) [2022-02-24T19:06:32Z] <dduvall@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.38.0-wmf.23 refs T300199