Page MenuHomePhabricator

Notify people when the comment they are responding to is edited
Open, Needs TriagePublic

Description

T250295 introduces an alert within the Reply Tool to make people aware when a new comment(s) is added to a discussion they are drafting a comment within.

This task builds on the work done in T250295, to make people aware then the comment they are directly responding to is edited.

Story

As someone who is in the process of drafting a response to something someone else has said, I want to know when the comment to which I am responding has changed and be able to decide whether to see said change, so that I can decide whether I will make changes to the response I was in the midst of writing.

Requirements

.

Mockups

Approaches

  • Approach #1: Compare differences in HTML between comment/section revisions
  • Approach #2: Compare differences in wikitext between comment/section revisions

Open questions

  • 1. How might the interface prepare people for the range of change(s) they can expect to see upon engaging with the would-be call to action to "show changes"?
    • Where "range of change(s)" in this context means things like: people have removed or added content to a comment that does/does not change said comment's meaning, people have removed or added formatting that does/does not change said comment's meaning, etc.
  • 2. How might we visualize changes in content?
    • One option: show people the wikitext diff interface. Tho, this approach would exclude changes in HTML which are the wikitext diff experience/infrastructure does not recognize and display.

i. @MichaelMaggs surfaced the need for finer change detection in Topic%3AWpvnsi3w4z2ke4yl writing, "The original motivation (Topic:Woomtgg3secx6r2h) was the concern was that changes can result in an embarrassing/socially difficult situation; but this prototype seems cover new comments only, and doesn't address the major concern that the specific post to which I am about to reply has been changed by its editor while I am typing. It's far more important to warn of changes to the comment being replied to than to warn of a new comment added perhaps several screens away from my current position within a long discussion section."

Event Timeline

Complexity
During today's team discussion, we talked about the complexity inherent with making people aware when a comment they are responding to is changed in a way they would value knowing about.

It's important to consider the "Complexities" below in the context of the value we assume resolving them will offer to people.

Complexities
In order to make people aware when a comment they are responding to is changed in a way they would value knowing about, we would need to:

  1. Define what changes people would value being notified about
  2. Write and maintain a list/algorithm that enables the software to detect the changes we'll have defined in "1)"
  3. Account for the fact that, right now, the software is comparing talk page versions using HTML whereas people are editing talk pages using wikitext. This means that in the [sometimes lossy] translation between wikitext and HTML false negatives and false positives could be triggered that could impact the usefulness of the feature. Read: The software could alert people about changes that are insignificant, potentially eroding peoples' trust in the alerts the tool is sending them. The software could also NOT alert people about changes they consider significant, again, potentially leading people to lose trust in the alerts the tool is sending them.
ppelberg renamed this task from Improve accuracy of discussion change detection to Notify people when the comment they are responding to is edited.Mar 7 2022, 4:14 AM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)

Meta

  • Open questions: I've updated the task description with the ===Open questions @Esanders shared with me in the meeting we had on 8 March 2022
  • Prioritization: the Editing Team is going to wait on prioritizing work on this ticket until we have a clearer sense for peoples' experience with T250295 and T300560.
    • E.g. "How noisy/valuable do people perceive the notifications they are seeing within the Reply Tool?" "On the spectrum of having too much awareness of changes to the discussion you are responding within and having too little awareness, where does the current experience sit?"
    • Knowing answers to questions like the above will help us to develop a better sense for peoples' tolerance for false positives/negatives and subsequently, the tradeoffs we are and are not willing to accept with the approach we eventually move forward with

make people aware then the comment they are directly responding to is edited.

People often reply to the last comment in a thread to generally comment on the topic, not only to reply to that specific comment. In such cases, people might reflect to any (and potentially multiple) comments, so changes to the technically-replied-to comment’s ancestors may be just as important. Since edits other than replies are usually rare in talk page topics anyway, I think alerts about any edits within the section would be more useful than annoying.