Thanks a lot for working on this. Can we also remove the old lib from apt and puppet?

root@apt1001:/srv/wikimedia# reprepro lsbycomponent libvarnishapi1
libvarnishapi1 | 5.1.3-1wm11 | stretch-wikimedia | main | amd64
libvarnishapi1 | 5.1.3-1wm15 |  buster-wikimedia | main | amd64

root@apt1001:/srv/wikimedia# reprepro lsbycomponent libvarnishapi2
libvarnishapi2 | 6.0.9-1wm1 | buster-wikimedia | component/varnish6 | amd64

The concern is that it ended up on new cp60xx nodes as well, so there must be something that brings it in.

@elukey, thanks for pointing that out. Yes we can do that, considering libvarnishapi1 was only required when we were using varnish 5.1.x of
which we no longer use in production, it is safe to have it removed there as well.

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:15:45Z] <mmandere> cp[6001-6016].drmrs.wmnet remove unused libvarnishapi1 T300247

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:27:48Z] <mmandere> cp[5006,5012].eqsin.wmnet remove unused libvarnishapi1 T300247

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:31:07Z] <mmandere> cp[4021,4025-4026,4032-4034,4036].ulsfo.wmnet remove unused libvarnishapi1 T300247

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:33:26Z] <mmandere> cp[3052,3064-3065].esams.wmnet remove unused libvarnishapi1 T300247

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:36:04Z] <mmandere> cp[2041-2042] remove unused libvarnishapi1 T300247

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:37:54Z] <mmandere> cp[1087,1089-1090] remove unused libvarnishapi1 T300247

We should probably add a Conflicts: libvarnishapi1 to our varnish 6 packaging, or whatever relationship magic is the right one to ensure that if varnish 6 is installed, libvarnishapi1 is not.

In T300247#7667111, @ema wrote:

We should probably add a Conflicts: libvarnishapi1 to our varnish 6 packaging, or whatever relationship magic is the right one to ensure that if varnish 6 is installed, libvarnishapi1 is not.

"Conflicts: libvarnishapi1" would do that, yes.