Page MenuHomePhabricator
Create Task
Maniphest T300332

Fix use of successbox in TranslationNotifications
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

See T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release for details.

Details

SubjectRepoBranchLines +/-
Fix use of successbox in TranslationNotificationsmediawiki/extensions/TranslationNotificationsmaster+5 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Jan 28 2022, 7:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2022, 7:18 AM
Nikerabbit added a parent task: T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release.Jan 28 2022, 7:18 AM
Nikerabbit set the point value for this task to 2.Mar 14 2022, 2:46 PM
abi_ triaged this task as Medium priority.Mar 15 2022, 9:13 AM
abi_ added a project: Language-Team (Language-2022-January-March).
abi_ moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-January-March) board.
abi_ subscribed.

Time sensitive task: Once MW 1.39 is released, users will start noticing visual inconsistencies.

Stang renamed this task from Fix uses of (error|success|warning|message)box in TranslationNotifications to Fix use of successbox in TranslationNotifications.Mar 20 2022, 11:12 PM
gerritbot added a comment.Mar 21 2022, 3:14 AM

Change 772055 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/extensions/TranslationNotifications@master] Fix use of successbox in TranslationNotifications

https://gerrit.wikimedia.org/r/772055

gerritbot added a project: Patch-For-Review.Mar 21 2022, 3:14 AM
abi_ assigned this task to Stang.Mar 21 2022, 5:01 AM
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2022-January-March) board.
gerritbot added a comment.Mar 22 2022, 3:48 AM

Change 772055 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Fix use of successbox in TranslationNotifications

https://gerrit.wikimedia.org/r/772055

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.4; 2022-03-23).Mar 22 2022, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 4:10 AM
Stang closed this task as Resolved.Mar 23 2022, 1:55 PM
Nikerabbit reopened this task as Open.Mar 28 2022, 4:55 PM
Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-January-March) board.

I'm assuming this wasn't yet verified in production.

Pginer-WMF edited projects, added Language-Team (Language-2022-April-June); removed Language-Team (Language-2022-January-March).Apr 4 2022, 8:24 AM
Pginer-WMF moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2022-April-June) board.
Nikerabbit closed this task as Resolved.Apr 5 2022, 7:47 AM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-April-June) board.

Verified in production.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL