See parent task. We rely on the warningbox class (added by MediaWiki core) in one browser test (client/data-bridge/tests/selenium/specs/errorHandling.js); as soon as MediaWiki core also emits the new class, change the browser test to use that instead.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Warningbox class is deprecated | Jdlrobson | mediawiki/extensions/Wikibase | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T299625 Bug: New language notice inconsistently styled across wikis | |||
| Resolved | Jdlrobson | T270796 Message boxes classes should carry `mw-` | |||
| Resolved | Jdlrobson | T300306 [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release | |||
| Resolved | Jdlrobson | T300356 Fix use of warningbox in Wikibase (error handling selenium test) | |||
| Resolved | Stang | T300358 Fix uses of (error|warning)box (MediaWiki core) |
Event Timeline
Comment Actions
Change 772506 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/Wikibase@master] Warningbox class is deprecated
Comment Actions
Thanks for writing the Selenium test here. They are a really helpful way to identify what teams consider important functionality.
Since you went to the effort of writing a browser test, I've returned the favor by writing a fix.
Comment Actions
Change 772506 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Warningbox class is deprecated