Page MenuHomePhabricator

Handle play before placeholder is loaded
Open, Needs TriagePublic

Description

Currently if you happen to click play on an element before our MediaElement placeholders it, the audio will keep playing and it creates a confusing situation.

We should:

  1. if status = playing and player = inline then immediately load inline player
  2. if status = playing and player = dialog then immediately open the dialog

With the merged patch, this is already better, but it seems that it is simply not always possible to detect that a user has requests playback already, if playback did not actually start yet. The only solution i can think of in this situation, is by reusing the original video in the mediadialog, instead of cloning a new video player. There might be other advantages to this as well, but it requires some further investigation.

Event Timeline

Change 758101 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Handle media that is already playing

https://gerrit.wikimedia.org/r/758101

Change 758101 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Handle media that is already playing

https://gerrit.wikimedia.org/r/758101