Page MenuHomePhabricator

Structured task - "Watch this page" checkbox does not reflect watchlisted article state
Closed, ResolvedPublicBUG REPORT

Description

Two cases when "Watch this page" checkbox status would not match watchlisted status of a structured task article:
(a)

  • a user has "Add pages and files I edit to my watchlist" Preference-Watchlist option disabled
  • a user adds an article to the Watchlist by clicking on the star
  • a user sees the watchlisted article in the structured task recommendation on Homepage - goes to an article and does some editing
  • a dialog box will display the "Watch this page" checkbox unchecked - and if a user wouldn't check this box, Watchlisted article would become un-watched

(b)

    • from Homepage a user gets to a structured task article
    • and clicks on the star to add it to Watchlist before to start working on structured edits
    • after finishing doing structured task (accepting links or accepting an image) the "Publish changes" dialog displays the "Watch this page" checkbox disabled
  • clicking Publish would remove the article from the Watchlist

Screen Shot 2022-01-28 at 3.50.18 PM.png (639×816 px, 212 KB)

Note:

  • "Watch this page " for VE "Save your changes" dialog would reflect the watchlisted status of the edited page. The Console will display "Uncaught TypeError: this.checkboxesByName is null" though.
  • The issue is present only for Structured tasks

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh changed the subtype of this task from "Task" to "Bug Report".

Sounds like a bug we should prioritize fixing, so I've moved to the current sprint.

mewoph changed the task status from Open to In Progress.Jan 31 2022, 5:13 PM
mewoph claimed this task.

This patch sets the checkbox state based on watchdefault only. Reverting the patch should address this issue.

Here are the screen recordings showing the different checkbox states per watchdefault preference and the article being watched/unwatched:

With watchdefault ON:

With watchdefault OFF:

Change 758492 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Revert \"Structured Task: Set the default state of wpWatchthis checkbox based on watchdefault preference\"

https://gerrit.wikimedia.org/r/758492

Change 758492 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Revert \"Structured Task: Set the default state of wpWatchthis checkbox based on watchdefault preference\"

https://gerrit.wikimedia.org/r/758492

kostajh renamed this task from Structured task - "Watch this page" checkbox does not reflect wathlisted article state to Structured task - "Watch this page" checkbox does not reflect watchlisted article state .Feb 16 2022, 12:47 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.

Checked on testwki wmf.22 - works as expected: "Watch this page" checkbox correctly reflects the Watched state of an article.