Page MenuHomePhabricator

thread_signature missing in lqt.pg.sql
Closed, DuplicatePublic

Description

Author: petter.tornberg

Description:
The thread_signature column is missing from lqt.pg.sql, which results in LiquidThreads failing on thread creation. With the following error message:

A database error has occurred
Query: UPDATE thread SET thread_signature = '[[User:Admin|Admin]]' WHERE thread_id IS NULL
Function: Thread::doLazyUpdates
Error: 1 ERROR: column "thread_signature" of relation "thread" does not exist at character 54
Backtrace:
#0 /var/www/html/insite/wiki/includes/db/Database.php(538): DatabasePostgres->reportQueryError('ERROR: column ...', 1, 'UPDATE thread ...', 'Thread::doLazyU...', false)
#1 /var/www/html/insite/wiki/includes/db/Database.php(1212): DatabaseBase->query('UPDATE thread ...', 'Thread::doLazyU...')
#2 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/Thread.php(867): DatabaseBase->update('thread', Array, Array, 'Thread::doLazyU...')
#3 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/Thread.php(307): Thread->doLazyUpdates()
#4 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/Thread.php(1491): Thread->author()
#5 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/Thread.php(97): Thread->setSignature('[[User:Admin|Ad...')
#6 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/View.php(857): Thread::create(Object(Article), Object(Article), NULL, 0, 'Web page feedba...', 'New thread: Web...', NULL, '[[User:Admin|Ad...')
#7 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/View.php(404): LqtView::newPostMetadataUpdates(Array)
#8 /var/www/html/insite/wiki/extensions/LiquidThreads/pages/TalkpageView.php(307): LqtView->showNewThreadForm(Object(Article))
#9 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/Dispatch.php(57): TalkpageView->show()
#10 /var/www/html/insite/wiki/extensions/LiquidThreads/classes/Dispatch.php(182): LqtDispatch::talkpageMain(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#11 [internal function]: LqtDispatch::tryPage(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest), Object(MediaWiki))
#12 /var/www/html/insite/wiki/includes/Hooks.php(133): call_user_func_array(Array, Array)
#13 /var/www/html/insite/wiki/includes/Wiki.php(469): wfRunHooks('MediaWikiPerfor...', Array)
#14 /var/www/html/insite/wiki/includes/Wiki.php(70): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#15 /var/www/html/insite/wiki/index.php(117): MediaWiki->performRequestForTitle(Object(Title), Object(Article), Object(OutputPage), Object(User), Object(WebRequest))
#16 /var/www/html/insite/index.php(116): include('/var/www/html/i...')
#17 {main}

Should just be a matter of adding something like:
"thread_signature TEXT NOT NULL DEFAULT '',"
under "CREATE TABLE thread".
(I still consider it as major, since any non-SQL person would be in trouble.)


Version: unspecified
Severity: major
OS: Linux

Details

Reference
bz28042

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusAssignedTask
InvalidNone
DuplicateNone

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:33 PM
bzimport set Reference to bz28042.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Mar 14 2011, 4:42 PM

Related issue: bug 36204 comment 3

Jorm removed a subscriber: Jorm.Dec 26 2015, 7:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 26 2015, 7:28 PM
Jdforrester-WMF lowered the priority of this task from Normal to Lowest.Aug 4 2016, 11:34 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to Normal.Aug 24 2016, 7:30 PM

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.