Page MenuHomePhabricator
Create Task
Maniphest T300444

Too much space between paragraphs in visual diffs (e.g. multi-line comments)
Closed, ResolvedPublic
Actions

Description

In this visual diff, I see huge gaps between the list items that constitute a multi-line discussion reply:

https://meta.wikimedia.org/w/index.php?title=Community_Wishlist_Survey_2022/Larger_suggestions/Fix_parsing_inside_references&diff=22710256&oldid=22701651&diffmode=visual&visualdiff

image.png (2×3 px, 603 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (37ee8ffcd)mediawiki/extensions/VisualEditormaster+1 -1
DiffElement: Don't show meaningless spaces inside added block nodesVisualEditor/VisualEditormaster+3 -2
Customize query in gerrit

Event Timeline

matmarex created this task.Jan 29 2022, 9:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2022, 9:14 PM
gerritbot added a comment.Jan 29 2022, 9:21 PM

Change 758059 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] DiffElement: Don't show meaningless spaces inside added block nodes

https://gerrit.wikimedia.org/r/758059

gerritbot added a project: Patch-For-Review.Jan 29 2022, 9:21 PM
Esanders updated the task description. (Show Details)Jan 29 2022, 10:52 PM
Esanders subscribed.Jan 29 2022, 10:58 PM

Example diff on beta for testing: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:ESanders_(WMF)/sandbox&type=revision&diff=535939&oldid=512102&diffmode=visual&visualdiff

Before:

image.png (216×475 px, 11 KB)

After:

image.png (209×478 px, 11 KB)

gerritbot added a comment.Jan 29 2022, 10:59 PM

Change 758059 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] DiffElement: Don't show meaningless spaces inside added block nodes

https://gerrit.wikimedia.org/r/758059

Esanders renamed this task from Huge gaps in visual diffs of lists (e.g. discussion replies) to Too much space between paragraphs in visual diffs (e.g. multi-line comments).Jan 29 2022, 10:59 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 29 2022, 11:10 PM
Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 30 2022, 12:39 PM
gerritbot added a comment.Jan 31 2022, 5:16 PM

Change 758528 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (37ee8ffcd)

https://gerrit.wikimedia.org/r/758528

gerritbot added a project: Patch-For-Review.Jan 31 2022, 5:16 PM
gerritbot added a comment.Jan 31 2022, 5:34 PM

Change 758528 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (37ee8ffcd)

https://gerrit.wikimedia.org/r/758528

matmarex added a project: Editing-team (Kanban Board).Jan 31 2022, 5:35 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 31 2022, 6:00 PM
ppelberg closed this task as Resolved.Feb 4 2022, 8:44 PM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits