Page MenuHomePhabricator

Empty file comment shown as deleted on Special:Undelete
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Upload a file with an empty comment
  • Delete it
  • Go to undelete it

What happens?:
The empty comment is show as "Edit summary removed"

Screenshot 2022-01-30 163331.jpg (880×1 px, 199 KB)

What should have happened instead?:
No "Edit summary removed" is shown

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

Change 758094 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/core@master] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/758094

Reedy added subscribers: Pchelolo, Reedy.

This feels similar to T293783: ImageInfo iiprop=comment query returns empty comment as hidden and I suspect might be of a similar cause - fallout from rMW5455e5896782: Deprecate File::getUser in favor of File::getUploader (or a similar/related patch)?

Fixed for the API in rMWa68c0238edc1: ApiQueryImageInfo: don't show empty comments as deleted... Guess this might be a MW-1.37-release backport candidate too

CC @Pchelolo

Change 758094 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/core@master] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/758094

Or rMW50b010e5e82e: Don't throw away '0' edit summary ?

Change 758094 merged by jenkins-bot:

[mediawiki/core@master] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/758094

Umherirrender assigned this task to Dylsss.
Umherirrender removed a project: Patch-For-Review.

Change 764835 had a related patch set uploaded (by Reedy; author: Dylsss):

[mediawiki/core@REL1_37] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/764835

Change 764835 merged by jenkins-bot:

[mediawiki/core@REL1_37] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/764835