Empty file comment shown as deleted on Special:Undelete
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dylsss
	Jan 30 2022, 4:37 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Upload a file with an empty comment
Delete it
Go to undelete it

What happens?:
The empty comment is show as "Edit summary removed"

Screenshot 2022-01-30 163331.jpg (880×1 px, 199 KB)

What should have happened instead?:
No "Edit summary removed" is shown

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SpecialUndelete: Do not show empty comments as deleted	mediawiki/core	REL1_37	+2 -2
	SpecialUndelete: Do not show empty comments as deleted	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: rMW50b010e5e82e: Don't throw away '0' edit summary
T293783: ImageInfo iiprop=comment query returns empty comment as hidden
rMW5455e5896782: Deprecate File::getUser in favor of File::getUploader
rMWa68c0238edc1: ApiQueryImageInfo: don't show empty comments as deleted

Event Timeline

Dylsss created this task.Jan 30 2022, 4:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2022, 4:37 PM

Maintenance_bot added a project: Commons.Jan 30 2022, 4:46 PM

Change 758094 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/core@master] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/758094

gerritbot added a project: Patch-For-Review.Jan 30 2022, 4:51 PM

This feels similar to T293783: ImageInfo iiprop=comment query returns empty comment as hidden and I suspect might be of a similar cause - fallout from rMW5455e5896782: Deprecate File::getUser in favor of File::getUploader (or a similar/related patch)?

Fixed for the API in rMWa68c0238edc1: ApiQueryImageInfo: don't show empty comments as deleted... Guess this might be a MW-1.37-release backport candidate too

CC @Pchelolo

In T300462#7662148, @gerritbot wrote:

Change 758094 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/core@master] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/758094

Or rMW50b010e5e82e: Don't throw away '0' edit summary ?

Peachey88 removed a project: Commons.Jan 30 2022, 8:25 PM

Change 758094 merged by jenkins-bot:

[mediawiki/core@master] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/758094

Umherirrender closed this task as Resolved.Feb 22 2022, 9:41 PM

Umherirrender assigned this task to Dylsss.

Umherirrender removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 22 2022, 10:00 PM

Change 764835 had a related patch set uploaded (by Reedy; author: Dylsss):

[mediawiki/core@REL1_37] SpecialUndelete: Do not show empty comments as deleted

https://gerrit.wikimedia.org/r/764835