Page MenuHomePhabricator

Validate bank account data in "Create Payment" use case
Closed, ResolvedPublic8 Estimated Story Points

Description

Acceptance Criteria

  • Copy the kontocheck implementation (and System test) from the fundraising app to the payment repository
  • Change the build instructions in fundraising-frontend-docker to build a new release (e.g. :5-dev, :5-composer whenever a dependency changes).
  • The use case validates the Iban with the ValidateIban use case, passed in as a dependency of the "Create Payment" use case.

Implementation Notes

  • Adapt the namespace of the kontocheck IBAN validation to WMDE\Fundraising\PaymentContext\Services. Later tickets will also move the API services for external payment providers here.
  • Use a 8.1 version of the FUN docker images that contains the kontocheck extension
  • Refactor the CheckIbanUseCase to return a better response, e.g. two classes, a simple boolean or enum (Valid/Invalid).
  • Use the CheckIbanUseCase as a dependency of the CreatePayment use case.
  • BankDataValidator can probably be removed

Event Timeline

kai.nissen set the point value for this task to 3.
kai.nissen changed the point value for this task from 3 to 8.