Page MenuHomePhabricator
Create Task
Maniphest T300497

Add functionality to delete Message bundles
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Its OK if the translations are left behind as is the case currently with translatable pages, but warn the user about the same.

Details

SubjectRepoBranchLines +/-
Change the way we retrieve source language for a MessageBundlemediawiki/extensions/Translatemaster+2 -9
ElasticSearch update: Handle case where MessageHandle group is nullmediawiki/extensions/Translatemaster+14 -2
Rename DeleteTranslatablePageSpecialPagemediawiki/extensions/Translatemaster+3 -3
Add support to delete message bundlesmediawiki/extensions/Translatemaster+230 -140
Add PageDeleteLoggermediawiki/extensions/Translatemaster+82 -20
Rename TranslateDeleteJob to TranslatableBundleDeleteJobmediawiki/extensions/Translatemaster+15 -17
Use SubpageListBuilder when deleting translatable pagesmediawiki/extensions/Translatemaster+70 -77
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Jan 31 2022, 12:13 PM
Nikerabbit set the point value for this task to 4.Feb 9 2022, 2:16 PM
Nikerabbit triaged this task as High priority.Feb 14 2022, 11:24 AM
Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.
Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-January-March) board.Mar 1 2022, 9:28 AM
abi_ changed the task status from Open to In Progress.Mar 28 2022, 7:03 AM
abi_ claimed this task.
abi_ moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2022-January-March) board.
gerritbot added a comment.Mar 28 2022, 7:05 AM

Change 774370 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Use SubpageListBuilder when deleting translatable pages

https://gerrit.wikimedia.org/r/774370

gerritbot added a project: Patch-For-Review.Mar 28 2022, 7:05 AM
gerritbot added a comment.Mar 28 2022, 12:30 PM

Change 774463 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename TranslateDeleteJob to TranslatableBundleDeleteJob

https://gerrit.wikimedia.org/r/774463

gerritbot added a comment.Mar 28 2022, 12:30 PM

Change 774464 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add PageDeleteLogger

https://gerrit.wikimedia.org/r/774464

gerritbot added a comment.Mar 29 2022, 12:32 PM

Change 774817 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add support for deleting translatable bundles

https://gerrit.wikimedia.org/r/774817

Pginer-WMF edited projects, added Language-Team (Language-2022-April-June); removed Language-Team (Language-2022-January-March).Apr 4 2022, 8:26 AM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-April-June) board.
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-April-June) board.Apr 6 2022, 3:15 PM
gerritbot added a comment.Apr 8 2022, 12:29 PM

Change 778496 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Rename DeleteTranslatablePageSpecialPage

https://gerrit.wikimedia.org/r/778496

gerritbot added a comment.May 10 2022, 12:35 PM

Change 774370 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use SubpageListBuilder when deleting translatable pages

https://gerrit.wikimedia.org/r/774370

gerritbot added a comment.May 10 2022, 12:36 PM

Change 774463 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename TranslateDeleteJob to TranslatableBundleDeleteJob

https://gerrit.wikimedia.org/r/774463

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 10 2022, 1:00 PM
gerritbot added a comment.May 16 2022, 3:09 PM

Change 774464 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add PageDeleteLogger

https://gerrit.wikimedia.org/r/774464

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 17 2022, 7:00 AM
gerritbot added a comment.Jun 1 2022, 7:40 AM

Change 774817 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add support to delete message bundles

https://gerrit.wikimedia.org/r/774817

gerritbot added a comment.Jun 1 2022, 7:40 AM

Change 778496 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rename DeleteTranslatablePageSpecialPage

https://gerrit.wikimedia.org/r/778496

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.15; 2022-06-06); removed MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).Jun 1 2022, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 1 2022, 8:30 AM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.Jun 1 2022, 8:33 AM
abi_ added a comment.Jun 1 2022, 1:53 PM

Noticed the following error during testing on translatewiki.net:

[2022-06-01T13:44:54.616165+00:00] exception.ERROR: [99311eee2209cf767a70214c] [no req]   Error: Call to a member function getPageLanguage() on null {"exception":"[object] (Error(code: 0): Call to a member function getPageLanguage() on null at /srv/mediawiki/tags/2022-06-01_13:36:53/extensions/Translate/src/MessageBundleTranslation/MessageBundleMessageGroup.php:191)
[stacktrace]
#0 /srv/mediawiki/tags/2022-06-01_13:36:53/extensions/Translate/ttmserver/ElasticSearchTTMServer.php(252): MediaWiki\\Extension\\Translate\\MessageBundleTranslation\\MessageBundleMessageGroup->getSourceLanguage()
#1 /srv/mediawiki/tags/2022-06-01_13:36:53/extensions/Translate/ttmserver/TTMServerMessageUpdateJob.php(257): ElasticSearchTTMServer->update()
#2 /srv/mediawiki/tags/2022-06-01_13:36:53/extensions/Translate/ttmserver/TTMServerMessageUpdateJob.php(206): TTMServerMessageUpdateJob->updateItem()
#3 /srv/mediawiki/tags/2022-06-01_13:36:53/extensions/Translate/ttmserver/TTMServerMessageUpdateJob.php(144): TTMServerMessageUpdateJob->runCommand()
#4 /srv/mediawiki/tags/2022-06-01_13:36:53/extensions/Translate/ttmserver/TTMServerMessageUpdateJob.php(107): TTMServerMessageUpdateJob->runCommandWithRetry()
#5 /srv/mediawiki/tags/2022-06-01_13:36:53/includes/jobqueue/JobRunner.php(384): TTMServerMessageUpdateJob->run()
#6 /srv/mediawiki/tags/2022-06-01_13:36:53/includes/jobqueue/JobRunner.php(345): JobRunner->doExecuteJob()
#7 /srv/mediawiki/tags/2022-06-01_13:36:53/includes/jobqueue/JobRunner.php(249): JobRunner->executeJob()
#8 /srv/mediawiki/tags/2022-06-01_13:36:53/maintenance/runJobs.php(98): JobRunner->run()
#9 /srv/mediawiki/tags/2022-06-01_13:36:53/maintenance/includes/MaintenanceRunner.php(195): RunJobs->execute()
#10 /srv/mediawiki/tags/2022-06-01_13:36:53/maintenance/doMaintenance.php(85): MediaWiki\\Maintenance\\MaintenanceRunner->run()
#11 /srv/mediawiki/tags/2022-06-01_13:36:53/maintenance/runJobs.php(136): require_once('/srv/mediawiki/...')
#12 {main}
","exception_url":"[no req]","reqId":"99311eee2209cf767a70214c","caught_by":"other"} []
abi_ moved this task from Recheck after deployment to In Progress on the Language-Team (Language-2022-April-June) board.Jun 22 2022, 2:20 PM

We are still looking at fixing the above issue.

gerritbot added a comment.Jun 22 2022, 2:24 PM

Change 807109 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ElasticSearch update: Handle case where MessageHandle group is null

https://gerrit.wikimedia.org/r/807109

gerritbot added a project: Patch-For-Review.Jun 22 2022, 2:24 PM
abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-April-June) board.Jun 25 2022, 2:36 PM
gerritbot added a comment.Jun 27 2022, 9:44 AM

Change 807109 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ElasticSearch update: Handle case where MessageHandle group is null

https://gerrit.wikimedia.org/r/807109

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 27 2022, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2022, 10:30 AM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.Jun 27 2022, 2:46 PM
gerritbot added a comment.Jun 29 2022, 7:13 PM

Change 809662 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Change the way we retrieve source language for a MessageBundle

https://gerrit.wikimedia.org/r/809662

gerritbot added a project: Patch-For-Review.Jun 29 2022, 7:13 PM
gerritbot added a comment.Jun 30 2022, 10:43 AM

Change 809662 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Change the way we retrieve source language for a MessageBundle

https://gerrit.wikimedia.org/r/809662

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2022, 11:30 AM
abi_ closed this task as Resolved.Jun 30 2022, 2:49 PM
abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-April-June) board.

Issue mentioned here: T300497#7973938 has been fixed. Tested on Translatewiki.net.

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 11 2022, 10:01 PM
Nikerabbit moved this task from group management to message bundles on the MediaWiki-extensions-Translate board.Sep 5 2022, 2:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL