Page MenuHomePhabricator
Create Task
Maniphest T300503

WikiLambda: For ZFunctionCall::getReturnType, get return type from DB instead of hardcoded Z4
Closed, ResolvedPublic
Actions

Description

Currently (because we only use ZFunctionCall for the Z881 and Z885 built-ins, the method getReturnType returns the hardcoded value of Z4. This method should, instead, query the secondary labels table and get the return type of the function.

Details

SubjectRepoBranchLines +/-
Remove hardcoded value from ZFunctionCall::getReturnTypemediawiki/extensions/WikiLambdamaster+78 -27
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Jan 31 2022, 1:43 PM
gengh added a project: WikiLambda.Jan 31 2022, 2:06 PM
DMartin-WMF mentioned this in T298131: [WikiLambda] Add more and stronger tests for ZFunctionCall.Feb 3 2022, 5:53 AM
gengh claimed this task.Feb 3 2022, 2:46 PM
gerritbot added a comment.Feb 4 2022, 12:25 PM

Change 759695 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Remove hardcoded value from ZFunctionCall::getReturnType

https://gerrit.wikimedia.org/r/759695

gerritbot added a project: Patch-For-Review.Feb 4 2022, 12:25 PM
gerritbot added a comment.Feb 4 2022, 10:20 PM

Change 759695 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove hardcoded value from ZFunctionCall::getReturnType

https://gerrit.wikimedia.org/r/759695

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 4 2022, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2022, 11:10 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Feb 8 2022, 5:15 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 8 2022, 5:16 PM
DVrandecic closed this task as Resolved.Feb 8 2022, 5:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL