Page MenuHomePhabricator
Create Task
Maniphest T300504

Poll for new replies in the section you are replying in
Closed, ResolvedPublic
Actions

Description

Will be used by T250295, and then connected to T300502

Proposed implementation:

  1. Send an API request with the last checked revision ID
  2. Do a quick check to see if the revision ID has changed
  3. If it has, comment parse the two revisions and see if there are any new comments in the new section
  4. Always return the new revision ID
  5. If there is a new comment(s) return metadata about it.
  6. The client checks if the new comment(s) is in the right section, then displays a notification

Details

SubjectRepoBranchLines +/-
Show error message as soon as we detect the parent comment has been deletedmediawiki/extensions/DiscussionToolsmaster+66 -6
Poll for new comments in the section you are replying inmediawiki/extensions/DiscussionToolsmaster+185 -5
Add discussiontoolscompare APImediawiki/extensions/DiscussionToolsmaster+212 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Jan 31 2022, 1:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2022, 1:47 PM
Esanders updated the task description. (Show Details)Jan 31 2022, 2:02 PM

I think we can separate out the new API in this commit and build on it: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/714059

If we have a generic commentdiff API that returns metadata of added/removed comments between two revisions (with "latest" allowed as an input) then this would satisfy this use case as well as T281624.

gerritbot added a comment.Jan 31 2022, 3:10 PM

Change 758479 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Add commentdiff API

https://gerrit.wikimedia.org/r/758479

gerritbot added a project: Patch-For-Review.Jan 31 2022, 3:10 PM
gerritbot added a comment.Jan 31 2022, 3:42 PM

Change 758485 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] WIP Poll for new comments in the section you are replying in

https://gerrit.wikimedia.org/r/758485

Esanders moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.Jan 31 2022, 4:47 PM
Esanders added a comment.Jan 31 2022, 6:29 PM

Question: Should we filter out new comments added by yourself (e.g. in another tab)?

PatchDemoBot added a comment.Jan 31 2022, 11:27 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/ff143b20a8/w/

Esanders added a comment.Feb 1 2022, 12:24 AM

WIP:

image.png (366×857 px, 37 KB)

• ppelberg added a subscriber: • ppelberg.Feb 1 2022, 8:37 PM

Polling timing
As discussed during today's team standup:

  1. To start, the feature will "poll" for new comments every 5 seconds
  2. If/when this polling cadence proves insufficient (e.g. people are consistently publishing comments and, to their surprise, finding new comments posted to the discussion they had not been alerted about), we will consider making revisions to the approach "1." describes.
    • One idea that came up: when people click/tap Reply, check whether any new comments have been posted to the discussion. If any new comments have been posted, do not publish the comment someone had been attempting to publish and instead, ask them to review the new comment that was posted or carry on with publishing the comment they originally intended to.
• ppelberg added a comment.EditedFeb 1 2022, 8:55 PM
In T300504#7665104, @Esanders wrote:

Question: Should we filter out new comments added by yourself (e.g. in another tab)?

To start, yes.

Thinking: let's stay true to the need this functionality is being designed to meet [i].

NOTE: I've updated T250295 to reflect the above.

i. Inform people when someone else changed the discussion they are drafting a comment with in so that they can decide whether they would like to make any changes to what they were drafting.

PatchDemoBot added a comment.Feb 2 2022, 5:59 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ff143b20a8/w/

PatchDemoBot added a comment.Feb 2 2022, 6:01 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/4e3b69dcb8/w/

PatchDemoBot added a comment.Feb 2 2022, 6:40 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/4e3b69dcb8/w/

PatchDemoBot added a comment.Feb 2 2022, 6:42 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/3d0dbc0868/w/

Esanders added a comment.EditedFeb 2 2022, 6:44 PM

The easiest way to test is to open the reply tool on an old revision of the page, so open a reply in this section:

https://patchdemo.wmflabs.org/wikis/c555f5ca84/w/index.php?title=Talk:DiscussionTools&oldid=23#Skip_to_Top_and_Skip_to_Bottom_arrows

You should eventually see "1 new comments have been added in this section." (Patch Demo is no the fastest)

gerritbot added a comment.Feb 3 2022, 10:09 PM

Change 759352 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Show error message as soon as we detect the parent comment has been deleted

https://gerrit.wikimedia.org/r/759352

PatchDemoBot added a comment.Feb 3 2022, 10:12 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/3d0dbc0868/w/

PatchDemoBot added a comment.Feb 3 2022, 10:14 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/c555f5ca84/w/

gerritbot added a comment.Feb 8 2022, 6:46 PM

Change 758479 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add discussiontoolscompare API

https://gerrit.wikimedia.org/r/758479

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 8 2022, 7:00 PM
• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Feb 10 2022, 4:21 PM
• ppelberg moved this task from Doing to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 14 2022, 6:29 PM
• ppelberg closed this task as Resolved.Feb 18 2022, 3:06 AM
• ppelberg claimed this task.
gerritbot added a comment.Mar 4 2022, 9:09 PM

Change 758485 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Poll for new comments in the section you are replying in

https://gerrit.wikimedia.org/r/758485

gerritbot added a comment.Mar 4 2022, 9:09 PM

Change 759352 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Show error message as soon as we detect the parent comment has been deleted

https://gerrit.wikimedia.org/r/759352

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2022, 9:10 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Mar 4 2022, 10:00 PM
PatchDemoBot added a comment.Mar 10 2022, 5:36 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c555f5ca84/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL