Page MenuHomePhabricator
Create Task
Maniphest T300571

No confirmation dialog when user selects to switch or exit out of Add image suggestion mode
Closed, InvalidPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  1. Open a suggested add image task

2a. Go to the editor dropdown and switch the editor mode to Visual Editor
OR
2b. Close the task using the close icon on the top left of the Suggested editor toolbar.

What happens?:
After 2a. --> the user is switched to the Visual Editor mode straightaway
After 2b. --> the user is switched to the Reading mode of the article straightaway

What should have happened instead?:
In both 2a and 2b, the user should see a confirmation dialog first (per T269653)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
cs beta
test wiki

Related Objects

Event Timeline

RHo created this task.Jan 31 2022, 8:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2022, 8:45 PM
• mewoph subscribed.EditedJan 31 2022, 9:11 PM

This is expected since the warning is only shown when there are unsaved changes, per this original requirement:

When the user selects the visual mode, they will get a modal that asks them to confirm they want to leave machine suggestions mode if they have unsaved changes regardless of whether useeditwarning preference is set. If they leave machine suggestions mode, their progress will be lost and unrecoverable.

RHo mentioned this in T269653: Add a link: edit mode toggle (machine suggestions & visual).Jan 31 2022, 10:04 PM
RHo mentioned this in T300582: Structured tasks: confirmation dialog when exit out of suggestion mode prior to making changes.Jan 31 2022, 10:16 PM
RHo closed this task as Invalid.Jan 31 2022, 10:18 PM
RHo added a subscriber: Tgr.
In T300571#7665647, @mewoph wrote:

This is expected since the warning is only shown when there are unsaved changes, per this original requirement:

When the user selects the visual mode, they will get a modal that asks them to confirm they want to leave machine suggestions mode if they have unsaved changes regardless of whether useeditwarning preference is set. If they leave machine suggestions mode, their progress will be lost and unrecoverable.

Ah yes thanks, @Tgr also pointed this out in an off-Phab discussion, so I have created a new task T300582 to discuss instead.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits