Page MenuHomePhabricator

Standardise type for timestamp columns in CentralAuth extension
Closed, ResolvedPublic

Description

According to T42626 the timestamp columns should be adjusted from varbinary(14) to binary(14) because there is no need to hold infinite.

And globaluser.gu_enabled is using DEFAULT '' which is not a valid timestamp.

Affected columns:

  • globaluser.gu_enabled
  • globaluser.gu_registration
  • globaluser.gu_password_reset_expiration
  • localuser.lu_attached_timestamp
  • renameuser_queue.rq_requested_ts
  • renameuser_queue.rq_completed_ts

Unaffected, because it has to hold infinite

  • global_user_groups.gug_expiry

Correct type:

  • globaluser.gu_email_authenticated

Event Timeline

taavi renamed this task from Standardise type for timestamp columns in OAuth extension to Standardise type for timestamp columns in CentralAuth extension.Jan 31 2022, 9:22 PM
Umherirrender triaged this task as Lowest priority.

Change 762531 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/762531

Change 762531 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/762531