Page MenuHomePhabricator

Remove unwanted space from language search results when suggested languages exist
Closed, ResolvedPublicBUG REPORT


When user searches for a language inside language searcher and no suggested languages exist, the results are rendered properly. However, when suggested languages do exist, an unwanted extra margin appears at the top of the results container, as demonstrated in the screencasts below.

Screencast when no suggested languages exist:

Screencast with suggested languages:

This extra space should be removed for UI consistency.

Event Timeline

Change 758587 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/MobileFrontend@master] Remove unwanted space from language search results

Change 758587 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove unwanted space from language search results

I'm still seeing the space.

With the Chrome inspector mobile simulator:

en.m.wikipedia.org_wiki_Apollo_5(iPhone SE).png (667×375 px, 20 KB)

On a real device:

photo1644398872.jpeg (1×591 px, 41 KB)

I think that this issue is already resolved, as demonstrated in the screenshot of English Wikipedia:

Screenshot 2022-03-02 at 12.30.35 PM.png (978×666 px, 43 KB)
. Moving this task to "Needs QA" column.

Etonkovidova added a subscriber: Etonkovidova.

Checked in wmf.24 - with a browser emulator and on{F34974422} real devices (iOS and Android). As per @ngkountas comment above - the issue seems to be resolved.