Today I was pooling new Prometheus hosts (T296199) and noticed that confctl will announce on IRC even if no action is taken (I set the weight of an host that I haven't added yet)
root@puppetmaster1001:~# confctl select name=prometheus1005.eqiad.wmnet set/pooled=yes WARNING:conftool.announce:conftool action : set/pooled=yes; selector: name=prometheus1005.eqiad.wmnet
Notice that there's no output indicating an action was taken, after I added the host then the output changed to
root@puppetmaster1001:~# confctl select name=prometheus1005.eqiad.wmnet set/weight=10 eqiad/prometheus/prometheus/prometheus1005.eqiad.wmnet: weight changed 0 => 10 WARNING:conftool.announce:conftool action : set/weight=10; selector: name=prometheus1005.eqiad.wmnet
I'd expect an announce/log entry only if an action was performed, otherwise IMHO announces/SAL can get confusing