Page MenuHomePhabricator

Don't mention "staging" or "dev" in "production" terraform code 🟦
Closed, ResolvedPublic3 Estimated Story Points

Description

Due to the speedy nature of our wikibase.cloud production terraform setup we chose to do some cleanup after getting things set up.
One thing that we noticed was that the copied setup left some variables etc with undesirable names, such as -dev- or -staging

We should eliminate these confusingly names values from our "production" setup, and generally unify these names

For example, if we have currently have a resource with the name resource-foo-staging in both production and staging terraforms, we probably just want this to be called resource-foo in both places

image.png (261×934 px, 77 KB)

AC:

  • Remove production/staging from recaptcha secrets in tf/env/staging/variables.tf and tf/env/production/variables.tf
  • Unify tf/env/staging/dns.tf and tf/env/production/dns.tf
  • Unify tf/env/staging/serviceaccount.tf and tf/env/production/serviceaccount.tf
  • (Optinal) Unify tf/env/staging/buckets.tf and tf/env/production/buckets.tf (Mainly touches the remote-state bucket which feels scary)

Event Timeline

dang removed dang as the assignee of this task.Feb 8 2022, 12:38 PM
dang moved this task from Doing to Review on the Wikibase.cloud (Launch Sprint 2 (2022)) board.
dang added a subscriber: dang.
This comment was removed by dang.
Addshore renamed this task from Don't mention "staging" or "dev" in "production" terraform code to Don't mention "staging" or "dev" in "production" terraform code 🟦.Feb 8 2022, 2:17 PM

Do we want to unify the dns and serviceaccount .tf as part of this ticket?

Do we want to unify the dns and serviceaccount .tf as part of this ticket?

I saw that in dns.tf has the name "dev-SOA" or "dev-A", etc.
In serviceaccount.tf we also have resource name such as "dev-api" so I think it need to be changed to just api

Tarrow set the point value for this task to 3.Feb 9 2022, 1:28 PM
toan removed toan as the assignee of this task.Feb 9 2022, 2:41 PM
toan updated the task description. (Show Details)
toan added a subscriber: toan.