Maniphest T300690

Civi should accept full_name in donation queue consumer
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Ejegg
	Feb 1 2022, 11:56 PM

Tags

Referenced Files

None

Subscribers

Eileenmcnaughton

Description

Should store the untouched full name in addressee_custom and use the name parsing library to break out likely first/last/middle/prefix/suffix. This logic is already happening for csv imports in ChecksFile::mungeMessage - we can remove it from there and put it in either the WMFContact::Save action or the wmf_civicrm_normalize_msg function.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Save initials to middle_name when blank	wikimedia/fundraising/crm	master	+1 -2
	Also clean full_name string	wikimedia/fundraising/crm	master	+35 -34
	Support full_name for all messages, not just ChecksFile	wikimedia/fundraising/crm	master	+51 -23

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ejegg	T244513 EPIC: Implement GPAY through adyen
		Resolved		None	T300690 Civi should accept full_name in donation queue consumer

Event Timeline

Ejegg created this task.Feb 1 2022, 11:56 PM

• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Feb 2 2022, 5:24 PM

• DStrine moved this task from Q3 2021-2022 to Sprint +3 on the Fundraising-Backlog board.

• DStrine added a project: FR-Gpay-Integration.Feb 11 2022, 9:41 PM

• DStrine moved this task from Sprint +3 to Sprint +1 on the Fundraising-Backlog board.Feb 11 2022, 9:47 PM

Change 769098 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Support full_name in Save, not just ChecksFile

https://gerrit.wikimedia.org/r/769098

gerritbot added a project: Patch-For-Review.Mar 8 2022, 7:28 PM

Ejegg triaged this task as Medium priority.Mar 9 2022, 3:03 AM

Ejegg added a project: Fundraising Sprint Discworld reformatted as ntfs.

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Discworld reformatted as ntfs board.

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Mar 13 2022, 6:27 PM

Change 769098 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Support full_name for all messages, not just ChecksFile

https://gerrit.wikimedia.org/r/769098

Change 770685 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Also clean full_name string

https://gerrit.wikimedia.org/r/770685

• DStrine added a project: Fundraising Sprint e^🥧👀=yum.Mar 15 2022, 8:34 PM

Eileenmcnaughton moved this task from Backlog to Review on the Fundraising Sprint e^🥧👀=yum board.Mar 15 2022, 8:44 PM

Just noting the main patch is pending deployment but there is a minor follow on in review https://gerrit.wikimedia.org/r/770685

Change 770685 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Also clean full_name string

https://gerrit.wikimedia.org/r/770685

jgleeson moved this task from Review to Pending Deployment on the Fundraising Sprint e^🥧👀=yum board.Mar 17 2022, 3:56 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2022, 4:11 PM

Eileenmcnaughton moved this task from Pending Deployment to Done on the Fundraising Sprint e^🥧👀=yum board.Mar 21 2022, 11:56 PM

• DStrine closed this task as Resolved.Mar 29 2022, 7:13 PM

• DStrine set Final Story Points to 2.

Change 777042 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Save initials to middle_name when blank

https://gerrit.wikimedia.org/r/777042

gerritbot added a project: Patch-For-Review.Apr 5 2022, 2:24 AM

Change 777042 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Save initials to middle_name when blank

https://gerrit.wikimedia.org/r/777042

Maintenance_bot removed a project: Patch-For-Review.Apr 5 2022, 3:30 AM