Page MenuHomePhabricator

Cartouche ends do not scale to fit the enclosed hieroglyphs
Open, LowestPublic

Description

Author: qleah

Description:


Version: master
Severity: normal
URL: http://en.wikipedia.org/wiki/Cartouche

Details

Reference
bz1007

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 8:01 PM
bzimport added a project: WikiHiero.
bzimport set Reference to bz1007.
bzimport added a subscriber: Unknown Object (MLST).

WORKSFORME. The page (permalink to at that time: http://en.wikipedia.org/w/index.php?title=Cartouche&oldid=9052615) appears OK to me (and Brion on IRC). The closing might be a *bit* off, but other than that, seems ok. Is this it?

Actually it does look kind of funny... Took these three examples out of [[Egyptian hieroglyphs]]:

http://www.mediawiki.org/wiki/Hiero_bug

The three separate names have different total box heights, but the cartouche ends are all scaled to 44 pixels high.

The problem seems to be that the images are all given a 1-pixel margin (WH_IMG_MARGIN) around them, but these don't seem to get taken into account when sizing up the cartouche boundary -- the ends are just scaled to WH_HEIGHT (44 pixels). As a result, vertical stacking of smaller glyphs vertically expands the inside of the cartouche, and the ends no longer match up.

Created attachment 5598
Screen shot showing differently-sized cartouches

Attached:

That page got deleted, here's repro wikitext:

<hiero>< N5:Z1-i-Y5:n-A40 ></hiero>

<hiero>< q:E23-i-V4-p:d:r-A-t:H8 ></hiero>

<hiero>< p:t-wA-l:M-i-i-s ></hiero>

Still looks bad. Venturing to say that this is an EASY bug.