Improve no parameter dialog state
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	awight
	Feb 2 2022, 9:27 AM

Project Tags

Referenced Files

	F35071948: No paramteters.png
	Apr 28 2022, 12:04 PM

	F35039809: No parameters state.png
	Apr 5 2022, 3:38 PM

	F35039810: No params - multi-part.png
	Apr 5 2022, 3:38 PM

	F35030092: No parameters state.png
	Mar 30 2022, 12:51 PM

	F35030093: No params - multi-part.png
	Mar 30 2022, 12:51 PM

	F35027393: No parameters state.png
	Mar 28 2022, 4:37 PM

	F34940380: image.png
	Feb 2 2022, 9:27 AM

Subscribers

Aklapper

awight

ECohen_WMDE

Description

Background

When a template has no TemplateData or takes no parameters, and the template invocation has no parameters, the sidebar is completely empty and looks broken.

Screenshot:

Requirements

Remove the no parameter message in main window
Add a no parameter message to the sidebar as placeholder text. Only show if no parameters. Disappears as soon as a parameter is added and re-appears on re-open if all undoc parameters are deleted. Message text This template has no documented parameters and may be intended for use without them.

Mocks

No parameters state.png (939×332 px, 33 KB)

No params - multi-part.png (900×666 px, 72 KB)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Move message about missing parameters to sidebar	WMDE-Fisch	mediawiki/extensions/VisualEditor	master	+26 -9

Customize query in gerrit

Related Objects

Mentioned In: T64417: TemplateData: Be able to specify a "no parameters accepted" definition
T309584: Fix margins/padding (VE template dialog)

Event Timeline

awight created this task.Feb 2 2022, 9:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2022, 9:27 AM

ECohen_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Mar 24 2022, 10:14 AM

ECohen_WMDE renamed this task from Design a better experience for templates with no parameters to Improve no parameter dialog state.Mar 28 2022, 4:37 PM

ECohen_WMDE updated the task description. (Show Details)

ECohen_WMDE moved this task from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.Mar 29 2022, 9:23 AM

ECohen_WMDE moved this task from Ready for story time to In preparation on the WMDE-Templates-FocusArea board.Mar 30 2022, 12:37 PM

ECohen_WMDE updated the task description. (Show Details)Mar 30 2022, 12:51 PM

ECohen_WMDE set the point value for this task to 3.Mar 30 2022, 2:02 PM

ECohen_WMDE updated the task description. (Show Details)Apr 5 2022, 3:38 PM

ECohen_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-04-27.Apr 27 2022, 9:31 AM

WMDE-Fisch moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.

WMDE-Fisch claimed this task.Apr 28 2022, 10:44 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-04-27 board.

Change 787487 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Move message about missing parameters to sidebar

https://gerrit.wikimedia.org/r/787487

gerritbot added a project: Patch-For-Review.Apr 28 2022, 11:56 AM

Quite some margins differ from what seems to be the base of the mocks above. But that's what the message looks like in the current patch ( multi transclusion version ):

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-04-27 board.Apr 28 2022, 12:05 PM

@ECohen_WMDE The old message box had links connected to some of the keywords[1]. Should the one in the sidebar include links as well? 🤔

[1]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:Templates#Parameters parameters]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:VisualEditor/User_guide#Adding_undocumented_parameters undocumented]

Change 787487 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move message about missing parameters to sidebar

https://gerrit.wikimedia.org/r/787487

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2022, 8:30 AM

thiemowmde moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-04-27 board.Apr 29 2022, 8:50 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 29 2022, 9:01 AM

In T300710#7887662, @WMDE-Fisch wrote:

@ECohen_WMDE The old message box had links connected to some of the keywords[1]. Should the one in the sidebar include links as well? 🤔

[1]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:Templates#Parameters parameters]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:VisualEditor/User_guide#Adding_undocumented_parameters undocumented]

I thought about this and had decided to leave them out in this context, keeping the sidebar from getting too busy. I think it's alright because the most important link to undoc parameters is still there in the description when button is clicked and the full component is visible for adding them.

Quite some margins differ from what seems to be the base of the mocks above. But that's what the message looks like in the current patch ( multi transclusion version ):

I would say don't mess with the margins too much at the moment. I'm in the process of a more wholistic review of this and will put all the specs in one follow-up ticket soon. After a quick look on beta, I would say you can leave this as-is for now.

awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-04-27 board.May 10 2022, 8:08 AM

WMDE-Fisch closed this task as Resolved.May 11 2022, 12:07 PM

ECohen_WMDE mentioned this in T309584: Fix margins/padding (VE template dialog).Jun 20 2022, 8:12 AM

thiemowmde mentioned this in T64417: TemplateData: Be able to specify a "no parameters accepted" definition.Mar 31 2023, 2:58 PM

Improve no parameter dialog stateClosed, ResolvedPublic3 Estimated Story PointsActions