Page MenuHomePhabricator

Improve no parameter dialog state
Closed, ResolvedPublic3 Estimated Story Points

Assigned To
Authored By
awight
Feb 2 2022, 9:27 AM
Referenced Files
F35071948: No paramteters.png
Apr 28 2022, 12:04 PM
F35039809: No parameters state.png
Apr 5 2022, 3:38 PM
F35039810: No params - multi-part.png
Apr 5 2022, 3:38 PM
F35030092: No parameters state.png
Mar 30 2022, 12:51 PM
F35030093: No params - multi-part.png
Mar 30 2022, 12:51 PM
F35027393: No parameters state.png
Mar 28 2022, 4:37 PM
F34940380: image.png
Feb 2 2022, 9:27 AM

Description

Background

When a template has no TemplateData or takes no parameters, and the template invocation has no parameters, the sidebar is completely empty and looks broken.

Screenshot:

image.png (890×914 px, 58 KB)

Requirements

  • Remove the no parameter message in main window
  • Add a no parameter message to the sidebar as placeholder text. Only show if no parameters. Disappears as soon as a parameter is added and re-appears on re-open if all undoc parameters are deleted. Message text This template has no documented parameters and may be intended for use without them.

Mocks

No parameters state.png (332×939 px, 33 KB)
No params - multi-part.png (666×900 px, 72 KB)

Event Timeline

ECohen_WMDE renamed this task from Design a better experience for templates with no parameters to Improve no parameter dialog state.Mar 28 2022, 4:37 PM
ECohen_WMDE updated the task description. (Show Details)
ECohen_WMDE set the point value for this task to 3.Mar 30 2022, 2:02 PM

Change 787487 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Move message about missing parameters to sidebar

https://gerrit.wikimedia.org/r/787487

Quite some margins differ from what seems to be the base of the mocks above. But that's what the message looks like in the current patch ( multi transclusion version ):

No paramteters.png (550×900 px, 111 KB)

@ECohen_WMDE The old message box had links connected to some of the keywords[1]. Should the one in the sidebar include links as well? 🤔

[1]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:Templates#Parameters parameters]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:VisualEditor/User_guide#Adding_undocumented_parameters undocumented]

Change 787487 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move message about missing parameters to sidebar

https://gerrit.wikimedia.org/r/787487

@ECohen_WMDE The old message box had links connected to some of the keywords[1]. Should the one in the sidebar include links as well? 🤔

[1]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:Templates#Parameters parameters]
[//www.mediawiki.org/wiki/Special:MyLanguage/Help:VisualEditor/User_guide#Adding_undocumented_parameters undocumented]

I thought about this and had decided to leave them out in this context, keeping the sidebar from getting too busy. I think it's alright because the most important link to undoc parameters is still there in the description when button is clicked and the full component is visible for adding them.

Quite some margins differ from what seems to be the base of the mocks above. But that's what the message looks like in the current patch ( multi transclusion version ):

I would say don't mess with the margins too much at the moment. I'm in the process of a more wholistic review of this and will put all the specs in one follow-up ticket soon. After a quick look on beta, I would say you can leave this as-is for now.