Page MenuHomePhabricator

People who've asked for old Vector are getting new Vector unexpectedly
Closed, ResolvedPublicBUG REPORT


Replication steps

  1. Set LocalSettings.php like so:
$wgSkipSkins = [ 'vector-2022' ];
$wgVectorDefaultSkinVersion = '1';
$wgVectorSkinMigrationMode  = false;
$wgVectorDefaultSkinVersionForExistingAccounts = '2';
$wgDefaultSkin = "vector";
  1. Go to Special:Preferences and opt into legacy Vector. (if it's already set, switch to another skin first)
  2. Set config to the following
$wgDefaultSkin = "vector-2022";
$wgSkipSkins = [ ];
$wgVectorSkinMigrationMode = true;
  1. Visit any page.

Expected: Get old skin
Actual: Get new skin

Event Timeline

I've got a unit test working for this. The issue was not caught during our previous QA as the configuration for pilot wikis does not match the one we actively develop and test with (localhost and beta cluster! Doh!)

Change 759283 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Skin version should be consulted for wikis where Vector is default

Okay after investigating this some more this is what happened:

The configuration for pilot wikis is different from the beta cluster and localhost. We didn't QA this configuration which is why we didn't notice this problem during code review or QA. The beta cluster should probably be updated to mirror the configuration on pilot wikis rather than English Wikipedia or we should QA on another beta cluster to avoid this problem in future (e.g.

The above check is what's missing. It will check if the skin version preference is set and if it is, also update the skin preference to the old Vector skin.

Jdlrobson triaged this task as High priority.

We talked about this in standup and it seems given a lot of the damage is done here and people are clearly find the way to opt out it may be safer to not do this. Moving to blocked in case we do want to do this after all.

Opt-outs are once again stable. Resolving.

Change 759283 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Skin version should be consulted for wikis where Vector is default


Per not needed.