People who've asked for old Vector are getting new Vector unexpectedly
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 2 2022, 5:14 PM

Description

Replication steps

Set LocalSettings.php like so:

$wgSkipSkins = [ 'vector-2022' ];
$wgVectorDefaultSkinVersion = '1';
$wgVectorSkinMigrationMode  = false;
$wgVectorDefaultSkinVersionForExistingAccounts = '2';
$wgDefaultSkin = "vector";

Go to Special:Preferences and opt into legacy Vector. (if it's already set, switch to another skin first)
Set config to the following

$wgDefaultSkin = "vector-2022";
$wgSkipSkins = [ ];
$wgVectorSkinMigrationMode = true;

Visit any page.

Expected: Get old skin
Actual: Get new skin

Details

	Subject	Repo	Branch	Lines +/-
	Skin version should be consulted for wikis where Vector is default	mediawiki/skins/Vector	master	+36 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T273473 [Epic] Improve the table of contents
Resolved		Jdrewniak	T291098 [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys
Resolved	BUG REPORT	ovasileva	T300757 People who've asked for old Vector are getting new Vector unexpectedly

Event Timeline

Jdlrobson created this task.Feb 2 2022, 5:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2022, 5:14 PM

cjming added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).Feb 2 2022, 5:20 PM

I've got a unit test working for this. The issue was not caught during our previous QA as the configuration for pilot wikis does not match the one we actively develop and test with (localhost and beta cluster! Doh!)

Change 759283 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] WIP: Skin version should be consulted for wikis where Vector is default

https://gerrit.wikimedia.org/r/759283

gerritbot added a project: Patch-For-Review.Feb 2 2022, 5:27 PM

Okay after investigating this some more this is what happened:

The configuration for pilot wikis is different from the beta cluster and localhost. We didn't QA this configuration which is why we didn't notice this problem during code review or QA. The beta cluster should probably be updated to mirror the configuration on pilot wikis rather than English Wikipedia or we should QA on another beta cluster to avoid this problem in future (e.g. https://he.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein)

The above check is what's missing. It will check if the skin version preference is set and if it is, also update the skin preference to the old Vector skin.

Jdlrobson claimed this task.Feb 2 2022, 6:10 PM

Jdlrobson triaged this task as High priority.

Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson mentioned this in T299971: [subtask] Problem in Legacy Vector calculation ([{reqId}] {exception_url} PHP Notice: Undefined index: data-user-page ).Feb 2 2022, 8:10 PM

IKhitron subscribed.Feb 3 2022, 2:58 AM

Aklapper mentioned this in T300828: Do not replace "New section" tab string with a plus equation sign.Feb 3 2022, 8:47 AM

ovasileva added a parent task: T291098: [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys.Feb 3 2022, 3:51 PM

Jdlrobson removed Jdlrobson as the assignee of this task.Feb 3 2022, 8:39 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

MusikAnimal mentioned this in T291098: [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys.Feb 4 2022, 5:44 AM

We talked about this in standup and it seems given a lot of the damage is done here and people are clearly find the way to opt out it may be safer to not do this. Moving to blocked in case we do want to do this after all.

Jdlrobson mentioned this in T301166: Update Beta cluster configuration for new and existing accounts.Feb 7 2022, 6:21 PM

Jdlrobson mentioned this in T298650: VectorPrefDiffInstrumentation should work for skin changes.Feb 8 2022, 10:45 PM

Jdlrobson mentioned this in T300919: It should be possible to set a default skin for existing users.Feb 11 2022, 5:44 PM

ovasileva moved this task from Blocked on Others to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 14 2022, 6:18 PM

Opt-outs are once again stable. Resolving.

Change 759283 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Skin version should be consulted for wikis where Vector is default

Reason:

Per https://phabricator.wikimedia.org/T300757 not needed.

https://gerrit.wikimedia.org/r/759283

Maintenance_bot removed a project: Patch-For-Review.Feb 18 2022, 12:10 AM