Page MenuHomePhabricator
Create Task
Maniphest T300773

Log whether a user views limited or full IP information
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

For T295017: Display ipinfo log lines on Special:Log we want to be able to show whether a user has viewed limited or full information (i.e. whether the user has the ipinfo-view-basic or ipinfo-view-full right.

To do this, we need to log it in Logger::log. We can log it as a parameter, using $logEntry->setParameters(), defined here.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Log the access level used when a user viewed IP informationmediawiki/extensions/IPInfomaster+107 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Feb 2 2022, 6:45 PM
Tchanders mentioned this in T295017: Display ipinfo log lines on Special:Log.Feb 2 2022, 6:49 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.
gerritbot added a comment.Feb 3 2022, 6:39 PM

Change 759562 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Log the access level used when a user viewed IP information

https://gerrit.wikimedia.org/r/759562

gerritbot added a project: Patch-For-Review.Feb 3 2022, 6:39 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Feb 3 2022, 6:40 PM
Tchanders added a subtask: T300135: Create a LoggerFactory service for IPInfo.Feb 4 2022, 5:16 PM
ARamirez_WMF set the point value for this task to 3.Feb 8 2022, 5:58 PM
ARamirez_WMF changed the point value for this task from 3 to 2.
Niharika closed subtask T300135: Create a LoggerFactory service for IPInfo as Resolved.Feb 17 2022, 1:34 AM
gerritbot added a comment.Feb 17 2022, 2:51 AM

Change 759562 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Log the access level used when a user viewed IP information

https://gerrit.wikimedia.org/r/759562

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 17 2022, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 17 2022, 3:10 AM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Feb 17 2022, 9:39 AM
Tchanders mentioned this in T292842: Log when the user's access level changes.Feb 17 2022, 10:24 AM
• imaigwilo subscribed.Feb 17 2022, 6:50 PM

QA front end testing will be done in https://phabricator.wikimedia.org/T295017

ARamirez_WMF edited projects, added Anti-Harassment-Team (AHaT Sprint 2: The Pork Pie); removed MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Anti-Harassment-Team (The Letter Song), IP Info.Feb 17 2022, 8:46 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 2: The Pork Pie) board.Feb 17 2022, 8:52 PM
• imaigwilo added a comment.EditedFeb 21 2022, 10:14 PM

Image shows full right and basic right user in logger table

Screen Shot 2022-02-21 at 5.02.52 PM.png (378×2 px, 178 KB)

Screen Shot 2022-02-22 at 10.51.38 PM.png (538×2 px, 250 KB)

Niharika added a project: IP Info.Feb 23 2022, 1:49 AM
• imaigwilo moved this task from QA/Testing 🐞 to Done Q3 2022 on the Anti-Harassment-Team (AHaT Sprint 2: The Pork Pie) board.Feb 23 2022, 4:11 AM
Niharika closed this task as Resolved.Mar 1 2022, 7:13 AM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits