Page MenuHomePhabricator

Refactor CirrusSearch WebdriverIO tests from sync to async mode
Closed, ResolvedPublic5 Estimated Story Points

Description

  • Follow instructions from CirrusSearch (Quickstart) to get MediaWiki working locally.
  • Refactor WebdriverIO tests (in tests/selenium) from sync to async mode.
  • Push code to Gerrit.

TODO

1# Cucumber-js
2
3This is the last version in the cucumber series. New releases will henceforth
4be made under the @cucumber/cucumber package name.
5
6By installing this version you are implicitly installing the new @cucumber/cucumber
7package.
8
9You should npm uninstall cucumber and then npm install --save-dev @cucumber/cucumber.
10
11After doing this you should replace your require or import statements to load
12@cucumber/cucumber instead of cucumber.
13
14If you are using TypeScript, npm uninstall @types/cucumber (v7 has types built-in). Also
15replace TableDefinition with DataTable if you are using these in your code.
16
17
18+ cucumber@7.0.0-rc.0
19added 112 packages from 247 contributors in 14.368s
20osamaahmedtahir@Users-MacBook-Pro CirrusSearch % npm run test
21
22> cirrussearch@0.0.0 test /Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch
23> grunt test
24
25Running "eslint:all" (eslint) task
26
27/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/integration/features/step_definitions/page_steps.js
28 12:61 error "cucumber" is not found node/no-missing-require
29
30/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/integration/features/step_definitions/search_steps.js
31 3:40 error "cucumber" is not found node/no-missing-require
32
33/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/integration/features/support/hooks.js
34 3:36 error "cucumber" is not found node/no-missing-require
35
36/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/integration/features/support/world.js
37 13:42 error "cucumber" is not found node/no-missing-require
38
39/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/phpunit/fixtures/configDump/enwiki_crosslang_frwiki_config.json
40 0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
41
42/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/phpunit/fixtures/configDump/enwiki_crosslang_frwiki_invalid_config.json
43 0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
44
45/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/phpunit/fixtures/configDump/enwiki_sisterproject_configs.json
46 0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
47
48/Users/osamaahmedtahir/Desktop/Outreachy/core/extensions/CirrusSearch/tests/phpunit/fixtures/regexParser/ref_impl_fixtures.json
49 0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
50
51✖ 8 problems (4 errors, 4 warnings)
52
53Warning: Task "eslint:all" failed. Use --force to continue.
54
55Aborted due to warnings.
56npm ERR! code ELIFECYCLE
57npm ERR! errno 3
58npm ERR! cirrussearch@0.0.0 test: `grunt test`
59npm ERR! Exit status 3
60npm ERR!
61npm ERR! Failed at the cirrussearch@0.0.0 test script.
62npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
63
64npm ERR! A complete log of this run can be found in:
65npm ERR! /Users/osamaahmedtahir/.npm/_logs/2022-02-09T22_34_55_790Z-debug.log

Event Timeline

@Osamaahmed17: Please set appropriate project tags (in this case CirrusSearch). Thanks.

Change 761483 had a related patch set uploaded (by Osamaahmed17; author: Osamaahmed17):

[mediawiki/extensions/CirrusSearch@master] selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/761483

Change 761483 abandoned by Zfilipin:

[mediawiki/extensions/CirrusSearch@master] selenium: Refactor WebdriverIO tests from sync to async mode

Reason:

https://gerrit.wikimedia.org/r/761483

dcausse subscribed.

moving back to needs triage as this starts to be blocking other teams

Change 942620 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Browser tests: stop using wdio/sync and fibers

https://gerrit.wikimedia.org/r/942620

Gehel set the point value for this task to 5.Aug 7 2023, 3:23 PM

Change 942620 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Browser tests: stop using wdio/sync and fibers

https://gerrit.wikimedia.org/r/942620

Since 942620 is merged, can this task be resolved? Is there anything left to do?

Gehel claimed this task.