Maniphest T300807

Refactor Termbox WebdriverIO tests from sync to async mode
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Acceptance criteria:

Follow instructions from wikibase/termbox to get Termbox working locally.
Refactor WebdriverIO tests (in tests/selenium) from sync to async mode.
Push code to Gerrit.
Browser tests are running on Gerrit

Details

	Subject	Repo	Branch	Lines +/-
	Termbox: re-enable browser tests	mediawiki/extensions/Wikibase	master	+3 -3
	Add missing `await`s to browser tests	wikibase/termbox	master	+4 -4
	Use `expect` instead of `assert` for browser tests	wikibase/termbox	master	+38 -57
	Migrate browser tests from sync to async	wikibase/termbox	master	+169 -169

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
		Open		None	T226869 Run browser tests in parallel
		Open		None	T344754 Browser tests video capture is shared between tests
		Resolved		None	T314468 Update vite to Version 3
		Open		None	T314470 Upgrade all CI jobs for WMF-deployed projects from Node 14 to Node 16
		Open		None	T210726 Selenium framework cleanup
		Open		None	T324685 Upgrade WebdriverIO to v8 in all repositories
		Stalled		None	T324318 Update Wikibase code bases to WebdriverIO v8
		Open		None	T256626 Refactor WebdriverIO tests from sync to async mode
		Open		None	T293080 Refactor Wikibase WebdriverIO tests from sync to async mode
		Resolved		Jakob_WMDE	T300807 Refactor Termbox WebdriverIO tests from sync to async mode

Event Timeline

Osamaahmed17 created this task.Feb 2 2022, 9:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2022, 9:54 PM

Osamaahmed17 updated the task description. (Show Details)Feb 2 2022, 9:54 PM

Osamaahmed17 mentioned this in T256626: Refactor WebdriverIO tests from sync to async mode.Feb 2 2022, 9:59 PM

@Osamaahmed17: Please set appropriate project tags (in this case Wikidata-Termbox). Thanks.

Maintenance_bot added a project: Wikidata.Feb 2 2022, 10:46 PM

zeljkofilipin added a parent task: T256626: Refactor WebdriverIO tests from sync to async mode.Feb 3 2022, 4:21 PM

zeljkofilipin added a project: User-zeljkofilipin.Feb 8 2022, 11:14 AM

Osamaahmed17 removed Osamaahmed17 as the assignee of this task.Feb 8 2022, 12:33 PM

Jakob_WMDE mentioned this in T293080: Refactor Wikibase WebdriverIO tests from sync to async mode.Aug 9 2023, 10:09 AM

Jakob_WMDE added a project: Wikibase Product Platform Team WPP.

Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to To polish on the Wikibase Product Platform Team WPP board.Aug 9 2023, 10:40 AM

Ifrahkhanyaree_WMDE updated the task description. (Show Details)Aug 9 2023, 12:12 PM

Ifrahkhanyaree_WMDE updated the task description. (Show Details)Aug 10 2023, 10:19 AM

Ifrahkhanyaree_WMDE set the point value for this task to 5.

Ifrahkhanyaree_WMDE moved this task from To polish to Ready for planning on the Wikibase Product Platform Team WPP board.

Michael added a subscriber: Michael.Aug 15 2023, 8:41 AM

Jakob_WMDE claimed this task.Aug 17 2023, 8:27 AM

Jakob_WMDE moved this task from Ready for planning to Sprint 1 on the Wikibase Product Platform Team WPP board.

Jakob_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 1); removed Wikibase Product Platform Team WPP.

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 1) board.

Change 949949 had a related patch set uploaded (by Jakob; author: Jakob):

[wikibase/termbox@master] Migrate browser tests from sync to async

https://gerrit.wikimedia.org/r/949949

gerritbot added a project: Patch-For-Review.Aug 17 2023, 11:23 AM

Change 949965 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Termbox: reenable browser tests

https://gerrit.wikimedia.org/r/949965

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 1) board.Aug 18 2023, 11:01 AM

zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.Aug 18 2023, 12:24 PM

Change 951069 had a related patch set uploaded (by Jakob; author: Jakob):

[wikibase/termbox@master] Use `expect` instead of `assert` for browser tests

https://gerrit.wikimedia.org/r/951069

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 2 ); removed Wikibase Product Platform Team WPP (Sprint 1).Aug 22 2023, 9:12 AM

Ifrahkhanyaree_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 2 ) board.

Change 949949 merged by jenkins-bot:

[wikibase/termbox@master] Migrate browser tests from sync to async

https://gerrit.wikimedia.org/r/949949

Jakob_WMDE mentioned this in rWBTB1845f6c56337: Migrate browser tests from sync to async.Aug 22 2023, 2:59 PM

Change 951069 merged by jenkins-bot:

[wikibase/termbox@master] Use `expect` instead of `assert` for browser tests

https://gerrit.wikimedia.org/r/951069

Ollie.Shotton_WMDE mentioned this in rWBTB4a5f6b50fbcb: Use `expect` instead of `assert` for browser tests.Aug 23 2023, 7:52 AM

Change 951842 had a related patch set uploaded (by Jakob; author: Jakob):

[wikibase/termbox@master] Add missing `await`s to browser tests

https://gerrit.wikimedia.org/r/951842

Change 951842 merged by jenkins-bot:

[wikibase/termbox@master] Add missing `await`s to browser tests

https://gerrit.wikimedia.org/r/951842

Jakob_WMDE mentioned this in rWBTB9be3aed6f407: Add missing `await`s to browser tests.Aug 23 2023, 9:30 AM

Change 949965 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Termbox: re-enable browser tests

https://gerrit.wikimedia.org/r/949965

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 2 ) board.Aug 23 2023, 9:45 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2023, 10:11 AM

Is this task resolved? All related commits are merged.

In T300807#9112911, @zeljkofilipin wrote:

Is this task resolved? All related commits are merged.

Yup

🎉

Ollie.Shotton_WMDE added a parent task: T293080: Refactor Wikibase WebdriverIO tests from sync to async mode.Aug 23 2023, 5:05 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 1:02 AM