Page MenuHomePhabricator

[betalabs] "Suggestions are no longer available on this article" is show for every image recommendation
Closed, ResolvedPublic

Description

  1. On enwiki betalabs select all topics and "Add image" structured task -the total count will be only 39.
  2. Click on any of the suggested articles - "Suggestions are no longer available on this article" message will be display.

Note: The issue is present only on betalabs wiki

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The error is No recommendation found for page, suggesting this is an issue with the image suggestions API (or the communication between the API and the extension). Could be beta-specific.

Tgr triaged this task as High priority.Feb 3 2022, 6:47 AM
Tgr edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.

Other beta wikis also fail but with Thumbnailing error.

The error is No recommendation found for page, suggesting this is an issue with the image suggestions API (or the communication between the API and the extension). Could be beta-specific.

Yes, it is beta-specific. But that prevents from all image recommendation testing.

Whatever thumbnailing problem beta had seems fixed now (probably T300751: InstantCommons is broken ). There is a new problem though: the task API doesn't return any returns, so only the first image (which is pre-rendered on the server side) is available. Not sure if that's beta-specific (can't reproduce it on testwiki, at least). Also, seems to affect some beta wikis only (cs but not en).

The error is No recommendation found for page, suggesting this is an issue with the image suggestions API (or the communication between the API and the extension). Could be beta-specific.

Beta enwiki suggested tasks genuinely don't have recommendations. Presumably all the articles we have imported last autumn already have images on production enwiki; we would have to import test tasks again.

There is a new problem though: the task API doesn't return any returns, so only the first image (which is pre-rendered on the server side) is available.

E.g. https://cs.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=jsonfm&list=growthtasks&gtlimit=20&gttasktypes=image-recommendation&formatversion=2&uselang=en

{
    "batchcomplete": true,
    "continue": {
        "gtoffset": 1,
        "continue": "-||"
    },
    "query": {
        "growthtasks": {
            "totalCount": 427,
            "qualityGateConfig": {
                "image-recommendation": {
                    "dailyLimit": false,
                    "dailyCount": 0
                }
            },
            "suggestions": []
        }
    }
}

somehow query continuation is triggered. Can't reliably reproduce though.

...or rather, can't reproduce at all anymore. I don't see any recent merges that would explain this, either. The behavior was consistent with $wgAPIMaxResultSize being very small (and so $fits always being false in ApiQueryGrowthTasks::execute()) so maybe someone was live-debugging? Or just mystical beta brokenness, which is unfortunately not all that rare.

In any case, all the issues here have fixed themselves, I think. @Etonkovidova can you confirm? Also, do you need a new batch of tasks imported to beta enwiki?

...or rather, can't reproduce at all anymore. I don't see any recent merges that would explain this, either. The behavior was consistent with $wgAPIMaxResultSize being very small (and so $fits always being false in ApiQueryGrowthTasks::execute()) so maybe someone was live-debugging? Or just mystical beta brokenness, which is unfortunately not all that rare.

In any case, all the issues here have fixed themselves, I think. @Etonkovidova can you confirm? Also, do you need a new batch of tasks imported to beta enwiki?

@Tgr cswiki betalabs has Add image tasks (the count is 290) and it works (no "Suggestions are no longer available on this article" message). enwiki betalabs still has old Add image tasks (the count is 39) - the warning "Suggestions are no longer available ..." will be displayed.