Discovered in QA of T294658: Create a log entry when the RevisionHandler is called. Logging while trying to expand the infobox (and therefore writing a user preference update to the db) results in a 500 error from the ip info api call because of a lock contention (at least in sqlite). Additionally, it's preferred practice to not write on the request [1]. Instead, the logging function should queue up the job and that way callers of the function (T294658: Create a log entry when the RevisionHandler is called and T294657: Create a log entry when the LogHandler is called) can continue to just call the function without worrying about how it's going about logging.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make LogIPInfoAccessJob | mediawiki/extensions/IPInfo | master | +53 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | STran | T300825 IPInfo logger should queue a logging job instead of writing directly | |||
| Resolved | STran | T294658 Create a log entry when the RevisionHandler is called | |||
| Resolved | • TThoabala | T294657 Create a log entry when the LogHandler is called | |||
| Resolved | phuedx | T294680 IP Info: Create a logger function to be used in both the popup and accordion presenters [M] |
Event Timeline
Comment Actions
Change 759570 had a related patch set uploaded (by STran; author: STran):
[mediawiki/extensions/IPInfo@master] Make LogIPInfoAccessJob
Comment Actions
Change 759570 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Make LogIPInfoAccessJob
Comment Actions
Moving to Done because this is a bit under-the-hood and will be tested via the parent tasks