Page MenuHomePhabricator
Create Task
Maniphest T300830

[M] When adding a date literal HTML with a span is shown
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Add a statement on Wikimedia Commons with P571 (inception)
  • Add a year like "1909"

What happens?:

  • Literal HTML is shown: "Will be displayed as: <span class="wbmi-input-widget--formatted">1909</span>"

grafik.png (286×860 px, 15 KB)

What should have happened instead?:

  • "Will be displayed as: 1909"

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

This happens since deployment of 1.38-wmf.20 (T293961)

Details

SubjectRepoBranchLines +/-
Fix date formatting escapingmediawiki/extensions/WikibaseMediaInfomaster+2 -4
Fix formatting issue for Date inputmediawiki/extensions/WikibaseMediaInfomaster+6 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT293961 1.38.0-wmf.20 deployment blockers
 ResolvedBUG REPORTSimoneThisDotT300830 [M] When adding a date literal HTML with a span is shown

Event Timeline

Raymond created this task.Feb 3 2022, 8:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2022, 8:24 AM
Raymond added a parent task: T293961: 1.38.0-wmf.20 deployment blockers.Feb 3 2022, 8:25 AM
Maintenance_bot added a project: Wikidata.Feb 3 2022, 8:45 AM
Zabe updated the task description. (Show Details)Feb 3 2022, 9:19 AM
CBogen added a project: Structured-Data-Backlog.Feb 3 2022, 2:06 PM
matthiasmullie subscribed.EditedFeb 3 2022, 3:26 PM

This hardly seems like a train blocker to me?
This doesn't impact security, performance, data integrity or substantially break anything in any way.
This looks terrible & we should fix it asap, but all in all it's just a minor (non-breaking) issue in a highly specific feature.

Agusbou2015 subscribed.Feb 3 2022, 6:35 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Feb 7 2022, 5:38 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Feb 7 2022, 5:42 PM
SimoneThisDot subscribed.Feb 9 2022, 1:35 PM

The above issue has been raised by the following patch T299289 with commit hash ee21ac272c4300b5c75f3d103e21c8e0258038eb

CBogen renamed this task from When adding a date literal HTML with a span is shown to [M] When adding a date literal HTML with a span is shown.Feb 9 2022, 5:56 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Feb 9 2022, 6:13 PM
SimoneThisDot claimed this task.Feb 11 2022, 1:16 PM
SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
Tol subscribed.Feb 14 2022, 6:05 AM
gerritbot added a comment.Feb 15 2022, 1:14 PM

Change 762813 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikibaseMediaInfo@master] Fix formatting issue for Date input

https://gerrit.wikimedia.org/r/762813

gerritbot added a project: Patch-For-Review.Feb 15 2022, 1:14 PM
gerritbot added a comment.Feb 15 2022, 10:05 PM

Change 762954 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/extensions/WikibaseMediaInfo@master] Fix date formatting escaping

https://gerrit.wikimedia.org/r/762954

Dominicbm merged a task: T302823: HTML elements in SDC popup.Mar 2 2022, 9:07 PM
Dominicbm subscribed.
gerritbot added a comment.Mar 4 2022, 3:25 PM

Change 762813 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Fix formatting issue for Date input

https://gerrit.wikimedia.org/r/762813

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 4 2022, 4:00 PM
SimoneThisDot moved this task from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.Mar 7 2022, 11:12 PM
Etonkovidova closed this task as Resolved.Mar 10 2022, 12:51 AM
Etonkovidova subscribed.

Checked on commons wmf.25 - works as expected; checked some other date-based statement - all look good.

Screen Shot 2022-03-09 at 4.42.48 PM.png (426×1 px, 51 KB)

gerritbot added a comment.Mar 18 2022, 10:01 AM

Change 762954 abandoned by Dylsss:

[mediawiki/extensions/WikibaseMediaInfo@master] Fix date formatting escaping

Reason:

https://gerrit.wikimedia.org/r/762954

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2022, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL