Page MenuHomePhabricator
Create Task
Maniphest T300981

Ensure extensionData can always be combined asynchronously/out-of-order
Open, MediumPublic
Actions

Description

See the parent task for the rationale.

Two sub tasks:

  • emit a deprecation warning, and later an exception, if ::setExtensionData is called multiple times with the same key and conflicting values
  • add an ::appendExtensionData method to allow collecting multiple values.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
WIP: hard-deprecate ParserOutput::setExtensionData() with conflicting valuesmediawiki/coremaster+27 -8
Use ParserOutput::appendExtensionData() for wikibase-entity-usagemediawiki/extensions/Wikibasemaster+15 -9
Add ParserOutput::appendExtensionData()mediawiki/coremaster+96 -9
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT300979 Ensure ParserOutput can always be combined asynchronously/out-of-order
OpenNoneT300981 Ensure extensionData can always be combined asynchronously/out-of-order
OpenNoneT301004 Use OutputPage::appendExtensionData for wikibase-otherprojects-sidebar
· · ·

Event Timeline

cscott created this task.Feb 4 2022, 3:46 PM
gerritbot added a comment.Feb 4 2022, 3:57 PM

Change 757938 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Add ParserOutput::appendExtensionData()

https://gerrit.wikimedia.org/r/757938

gerritbot added a project: Patch-For-Review.Feb 4 2022, 3:57 PM

Change 759728 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: hard-deprecate ParserOutput::setExtensionData() with conflicting values

https://gerrit.wikimedia.org/r/759728

gerritbot added a comment.Feb 4 2022, 8:38 PM

Change 759784 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Wikibase@master] Use ParserOutput::appendExtensionData() for wikibase-entity-usage

https://gerrit.wikimedia.org/r/759784

gerritbot added a comment.Feb 4 2022, 10:20 PM

Change 757938 merged by jenkins-bot:

[mediawiki/core@master] Add ParserOutput::appendExtensionData()

https://gerrit.wikimedia.org/r/757938

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 4 2022, 11:00 PM
Arlolra moved this task from Needs Triage to Missing Functionality on the Parsoid board.Feb 7 2022, 10:43 PM
gerritbot added a comment.Feb 11 2022, 11:44 PM

Change 759784 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use ParserOutput::appendExtensionData() for wikibase-entity-usage

https://gerrit.wikimedia.org/r/759784

ReleaseTaggerBot edited projects, added: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14); removed: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 12 2022, 12:00 AM
ssastry triaged this task as Medium priority.Jun 14 2022, 10:38 PM
ssastry added a project: Parsoid-Read-Views.
• JMcLeod_WMF moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Jul 28 2022, 2:14 PM
• JMcLeod_WMF edited projects, added: Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed: Parsoid-Read-Views.
ssastry edited projects, added: Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid); removed: Parsoid-Read-Views (Phase 1 - DiscussionTools support).Aug 4 2022, 6:25 PM
cscott mentioned this in T263772: Make RelatedArticles extension compatible with Parsoid .Dec 4 2023, 3:26 PM
Aklapper edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Apr 12 2024, 11:13 AM
Aklapper removed cscott as the assignee of this task.May 16 2024, 4:29 PM

@cscott: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

gerritbot added a comment.Mar 30 2026, 1:11 PM

Change #759728 abandoned by Hashar:

[mediawiki/core@master] WIP: hard-deprecate ParserOutput::setExtensionData() with conflicting values

https://gerrit.wikimedia.org/r/759728

gerritbot added a comment.Mar 30 2026, 11:13 PM

Change #759728 restored by Thcipriani:

[mediawiki/core@master] WIP: hard-deprecate ParserOutput::setExtensionData() with conflicting values

https://gerrit.wikimedia.org/r/759728

gerritbot added a project: Patch-For-Review.Mar 30 2026, 11:13 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMar 30 2026, 11:13 PM
Pppery edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Mar 31 2026, 2:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits