Page MenuHomePhabricator
Create Task
Maniphest T300986

Ensure Page Properties can always be combined asynchronously/out-of-order
Open, MediumPublic
Actions

Description

Setting the same page property multiple times with conflicting values is inconsistent with an asynchronous/out-of-order parsing model.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Store `noexternallanglinks` in extension data, not page propertymediawiki/extensions/Wikibasemaster+73 -33
Deprecate ParserOutput::setPageProperty with conflicting valuesmediawiki/coremaster+12 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT396539 Introduce a way to edit a span of text from within read mode
 OpenNoneT385558 Improve copy and paste from read mode to VE
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 OpenNoneT272987 [EPIC] Parsoid read views for DiscussionTools
 OpenNoneT297840 Populate ParserCache with Parsoid output as a post-edit hook
 OpenNoneT393717 Put lints in ParserOutput/RefreshLinksJob
 OpenBUG REPORTNoneT393682 Wikifunctions fragments that trigger errors and try to put the page in a tracking category show it at the bottom of the view page, but the pages using the fragment do not appear on the category page
 OpenNoneT409815 SLI: MediaWiki system load
 OpenNoneT393716 [EPIC] RefreshLinksJob should use Parsoid-generated metadata
 OpenNoneT310511 Metadata comparison testing between Parsoid and the legacy parser
 OpenNoneT310512 Parsoid and the legacy parser should emit exactly the same ParserOutput metadata
 OpenNoneT305159 Improve coverage of the ContentMetadataCollector interface
 OpenNoneT300979 Ensure ParserOutput can always be combined asynchronously/out-of-order
 OpenNoneT300986 Ensure Page Properties can always be combined asynchronously/out-of-order
 OpenNoneT331483 Resolve differences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content
 ResolvedcscottT213468 Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded
 ResolvedABreault-WMFT215628 Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use
 ResolvedcscottT214538 MediaWiki shouldn't assign section numbers during tokenization, but instead only when headings are generated
 OpencscottT359221 Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently
 ResolvedssastryT359450 Parsoid is not adding headings to TOC entries in some templated content scenarios
 ResolvedJgiannelosT402456 More Parsoid TOC edge cases?
 OpenJgiannelosT415554 From TOC difftesting (legacy/parsoid): Differences in template handling from sections
 OpenJgiannelosT415558 From TOC difftesting (legacy/parsoid): Mismatch when sections come from the same article
 OpenJgiannelosT415563 From TOC difftesting (legacy/parsoid): Inconsistent index level between legacy and parsoid
 OpenJgiannelosT415565 From TOC difftesting (legacy/parsoid): Section titles wrapped in html elements on parsoid
 ResolvedJgiannelosT403188 Implement TOC comparison in Linter extension

Event Timeline

cscott created this task.Feb 4 2022, 4:43 PM
gerritbot added a project: Patch-For-Review.Feb 4 2022, 4:47 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2022, 5:10 PM
Arlolra moved this task from Needs Triage to Missing Functionality on the Parsoid board.Feb 7 2022, 10:43 PM
cscott added a comment.Feb 17 2022, 10:24 PM

As part of this work, we should probably also deprecate ParserOutput::unsetPageProperty().
It is hardly used: https://codesearch.wmcloud.org/search/?q=unsetPageProperty&i=nope&files=&excludeFiles=&repos=

Unfortunately the use in Wikibase is a little nontrivial to get rid of. It's being used to clear all 'badge' related page properties before adding the new ones for an item. I strongly suspect that it is almost always doing nothing, because the pre-existing badge properties are either identical to the ones being set, or empty, but I'd need to understand what's going on with badges in wikibase a little better to be able to be confident of this.

gerritbot added a comment.Feb 17 2022, 10:25 PM

Change 757905 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate ParserOutput::setPageProperty with conflicting values

https://gerrit.wikimedia.org/r/757905

gerritbot added a project: Patch-For-Review.Feb 17 2022, 10:25 PM
gerritbot added a comment.Mar 10 2022, 11:27 PM

Change 759740 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Store `noexternallanglinks` in extension data, not page property

https://gerrit.wikimedia.org/r/759740

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 11 2022, 12:00 AM
ssastry triaged this task as Medium priority.Jun 14 2022, 10:38 PM
ssastry added a project: Parsoid-Read-Views.
• JMcLeod_WMF moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Jul 28 2022, 2:14 PM
• JMcLeod_WMF edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.
ssastry edited projects, added Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid); removed Parsoid-Read-Views (Phase 1 - DiscussionTools support).Aug 4 2022, 6:24 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 12 2024, 11:13 AM
Aklapper removed cscott as the assignee of this task.May 16 2024, 4:29 PM

@cscott: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits