Page MenuHomePhabricator
Create Task
Maniphest T301003

TypeError: Argument 1 passed to MediaWiki\Minerva\Menu\Main\DefaultMainMenuBuilder::getDiscoveryGroup() must be of the type array, null given, called in /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php on line 101
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Hello en.wikibooks.beta.wmflabs.org has an error. Can you see it. Thanks!

MediaWiki internal error.

Original exception: [Yf2Iq81KlJKDQ5UpTo9ODgAAAA4] /wiki/Main_Page TypeError: Argument 1 passed to MediaWiki\Minerva\Menu\Main\DefaultMainMenuBuilder::getDiscoveryGroup() must be of the type array, null given, called in /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php on line 101
Backtrace:
from /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/DefaultMainMenuBuilder.php(74)
#0 /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php(101): MediaWiki\Minerva\Menu\Main\DefaultMainMenuBuilder->getDiscoveryGroup(NULL)
#1 /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php(79): MediaWiki\Minerva\Menu\Main\MainMenuDirector->buildMenu(array, array)
#2 /srv/mediawiki/php-master/skins/MinervaNeue/includes/Skins/SkinMinerva.php(134): MediaWiki\Minerva\Menu\Main\MainMenuDirector->getMenuData(array, array)
#3 /srv/mediawiki/php-master/includes/skins/SkinMustache.php(58): SkinMinerva->getTemplateData()
#4 /srv/mediawiki/php-master/includes/skins/SkinTemplate.php(147): SkinMustache->generateHTML()
#5 /srv/mediawiki/php-master/includes/OutputPage.php(2711): SkinTemplate->outputPage()
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(917): OutputPage->output(boolean)
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(930): MediaWiki::{closure}()
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(563): MediaWiki->main()
#9 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Exception caught inside exception handler: [Yf2Iq81KlJKDQ5UpTo9ODgAAAA4] /wiki/Main_Page TypeError: Argument 1 passed to MediaWiki\Minerva\Menu\Main\DefaultMainMenuBuilder::getDiscoveryGroup() must be of the type array, null given, called in /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php on line 101
Backtrace:
from /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/DefaultMainMenuBuilder.php(74)
#0 /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php(101): MediaWiki\Minerva\Menu\Main\DefaultMainMenuBuilder->getDiscoveryGroup(NULL)
#1 /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php(79): MediaWiki\Minerva\Menu\Main\MainMenuDirector->buildMenu(array, array)
#2 /srv/mediawiki/php-master/skins/MinervaNeue/includes/Skins/SkinMinerva.php(134): MediaWiki\Minerva\Menu\Main\MainMenuDirector->getMenuData(array, array)
#3 /srv/mediawiki/php-master/includes/skins/SkinMustache.php(58): SkinMinerva->getTemplateData()
#4 /srv/mediawiki/php-master/includes/skins/SkinTemplate.php(147): SkinMustache->generateHTML()
#5 /srv/mediawiki/php-master/includes/OutputPage.php(2711): SkinTemplate->outputPage()
#6 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(158): OutputPage->output()
#7 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(77): MWExceptionRenderer::reportHTML(TypeError)
#8 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(107): MWExceptionRenderer::output(TypeError, integer)
#9 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(202): MWExceptionHandler::report(TypeError)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(585): MWExceptionHandler::handleException(TypeError, string)
#11 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#12 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Details

MediaWiki Version
master
Request URL
https://en.m.wikibooks.beta.wmflabs.org/wiki/Main_Page
SubjectRepoBranchLines +/-
Handle unexpected data coming from MediaWiki:Sidebarmediawiki/skins/MinervaNeuemaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

AlPaD created this task.Feb 4 2022, 7:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2022, 7:50 PM
AlPaD updated the task description. (Show Details)Feb 4 2022, 7:51 PM
AlPaD updated the task description. (Show Details)
RhinosF1 renamed this task from Error to TypeError: Argument 1 passed to MediaWiki\Minerva\Menu\Main\DefaultMainMenuBuilder::getDiscoveryGroup() must be of the type array, null given, called in /srv/mediawiki/php-master/skins/MinervaNeue/includes/Menu/Main/MainMenuDirector.php on line 101.Feb 4 2022, 8:13 PM
RhinosF1 triaged this task as Unbreak Now! priority.
RhinosF1 added a project: MinervaNeue.
Restricted Application added subscribers: RhinosF1, Masumrezarock100. · View Herald TranscriptFeb 4 2022, 8:13 PM
RhinosF1 changed the subtype of this task from "Task" to "Production Error".Feb 4 2022, 8:13 PM
RhinosF1 set Request URL to https://en.m.wikibooks.beta.wmflabs.org/wiki/Main_Page.
RhinosF1 updated the task description. (Show Details)
RhinosF1 set Release Version to master.
RhinosF1 added a parent task: T300197: 1.38.0-wmf.21 deployment blockers.Feb 4 2022, 8:17 PM
• dduvall subscribed.Feb 4 2022, 8:18 PM

Git points to T291568: Minerva menus should use data from core hooks (deprecate MobileMenu hook) and https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/755046

• dduvall added a project: Growth-Team.Feb 4 2022, 8:18 PM
• dduvall added a subscriber: Jdlrobson.
Zabe updated the task description. (Show Details)Feb 4 2022, 8:19 PM
RhinosF1 added a project: Web-Team-Backlog.Feb 4 2022, 8:22 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.Feb 4 2022, 8:27 PM

Leave it with us. I'll make sure it's fixed or reverted before the train rolls out.

• dduvall awarded a token.Feb 4 2022, 8:29 PM
AlPaD added a comment.Feb 4 2022, 8:32 PM

Thank you very much!

Jdlrobson added a comment.Feb 4 2022, 9:17 PM

It's happening because of the uppercase N in Navigation in https://en.wikibooks.beta.wmflabs.org/wiki/MediaWiki:Sidebar
Looks like 18 wikis would be impacted:
https://global-search.toolforge.org/?q=%5C*+Navigation&regex=1&namespaces=&title=Sidebar

Short term fix coming, but it seems poor design that MediaWiki:Sidebar allows this to happen as this results in different ID's such as #p-Navigation which in turn breaks gadgets. I'll open a follow up task.

gerritbot added a comment.Feb 4 2022, 9:18 PM

Change 759796 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Handle unexpected data coming from MediaWiki:Sidebar

https://gerrit.wikimedia.org/r/759796

gerritbot added a project: Patch-For-Review.Feb 4 2022, 9:18 PM
Jdlrobson mentioned this in T301010: MediaWiki:Sidebar sections should be lowercased and navigation menu always present.Feb 4 2022, 9:27 PM
gerritbot added a comment.Feb 4 2022, 9:38 PM

Change 759796 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Handle unexpected data coming from MediaWiki:Sidebar

https://gerrit.wikimedia.org/r/759796

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 4 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2022, 10:10 PM
Jdlrobson closed this task as Resolved.Feb 4 2022, 10:28 PM
Jdlrobson claimed this task.

Working again.
https://en.m.wikibooks.beta.wmflabs.org/wiki/MediaWiki:Sidebar

RhinosF1 added a comment.Feb 5 2022, 7:47 AM

Thanks for the quick fix!

AlPaD added a comment.EditedFeb 5 2022, 7:49 AM

Yes. Thanks for your good job :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL