Page MenuHomePhabricator
Create Task
Maniphest T301056

Have consistent spacing between icon and text label in all menus
Closed, ResolvedPublic
Actions

Assigned To
• alexhollender_WMF
Authored By
BrandonXLF
Feb 6 2022, 1:27 AM
Tags
Referenced Files
F34945812: p personal after.PNG
Feb 8 2022, 7:11 PM
F34945809: p nav before.PNG
Feb 8 2022, 7:11 PM
F34945811: p personal before.PNG
Feb 8 2022, 7:11 PM
F34945810: p nav after.PNG
Feb 8 2022, 7:11 PM
F34943262: image.png
Feb 6 2022, 1:27 AM
F34943264: image.png
Feb 6 2022, 1:27 AM
Subscribers
Aklapper
• alexhollender_WMF
BrandonXLF
Jdlrobson
Masumrezarock100
ovasileva

Description

Right now items in the user dropdown menu and items added to the main menu using mw.util.addPortletLink have an extra   between the icon and the text in addition to the margin, this should be removed. The space was removed from the main menu in PHP as a part of T292452 with this change, but the change was never applied to mw.util.addPortletLink or the user menu.

image.png (174×222 px, 7 KB)

In the main menu, you can see that the icons added by the skin in PHP don't have the extra space, but the "Foo" menu item that was added using mw.util.addPortletLink does.

image.png (300×239 px, 9 KB)

In the user menu, all the menu item have the extra space.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix spacing between icon + text in toggle menu and JSmediawiki/skins/MinervaNeuemaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

BrandonXLF created this task.Feb 6 2022, 1:27 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 6 2022, 1:27 AM
gerritbot added a comment.Feb 6 2022, 1:31 AM

Change 759972 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[mediawiki/skins/MinervaNeue@master] Fix spacing between icon + text in toggle menu and JS

https://gerrit.wikimedia.org/r/759972

gerritbot added a project: Patch-For-Review.Feb 6 2022, 1:31 AM
Jdlrobson added subscribers: ovasileva, Jdlrobson.Feb 7 2022, 10:31 PM

@ovasileva there is a patch from a volunteer for this one. Should we move into the sprint board?

ovasileva edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed Web-Team-Backlog-Archived.Feb 8 2022, 12:12 PM
ovasileva added a subscriber: • alexhollender_WMF.

Sure, we can review. @alexhollender_WMF - just double checking this change fits our expectations

ovasileva triaged this task as Low priority.Feb 8 2022, 12:12 PM
• alexhollender_WMF added a comment.Feb 8 2022, 3:28 PM

@Jdlrobson @BrandonXLF is it possible to see a before & after comparison of this change?

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Feb 8 2022, 5:59 PM
BrandonXLF added a comment.Feb 8 2022, 7:11 PM
In T301056#7693446, @alexhollender_WMF wrote:

@Jdlrobson @BrandonXLF is it possible to see a before & after comparison of this change?

Here are before and after screenshots. The first row is for the p-navigation portlet menu and the second row is for the p-personal popup menu.

BeforeAfter
p nav before.PNG (364×329 px, 6 KB)
p nav after.PNG (359×330 px, 6 KB)
p personal before.PNG (430×227 px, 7 KB)
p personal after.PNG (411×218 px, 7 KB)
• alexhollender_WMF added a comment.Feb 10 2022, 2:35 PM

@BrandonXLF thanks for the screenshots, looks fine to me.

gerritbot added a comment.Feb 10 2022, 4:54 PM

Change 759972 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix spacing between icon + text in toggle menu and JS

https://gerrit.wikimedia.org/r/759972

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 10 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2022, 5:11 PM
Jdlrobson assigned this task to • alexhollender_WMF.Feb 10 2022, 5:47 PM

This can now be design reviewed on the beta cluster. Feel free to move to sign off if all looks good. Be sure to check menus in AMC as well as outside AMC.

• alexhollender_WMF moved this task from Upcoming to Design Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Feb 10 2022, 6:05 PM
Jdlrobson mentioned this in T307233: Minerva mobile: non-ASCII char in section heading cause bigger margin.May 2 2022, 3:40 PM
ovasileva added a subtask: T307233: Minerva mobile: non-ASCII char in section heading cause bigger margin.May 3 2022, 1:03 PM
Jdlrobson moved this task from Design Review to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.May 31 2022, 5:12 PM
ppelberg closed subtask T307233: Minerva mobile: non-ASCII char in section heading cause bigger margin as Resolved.Jun 3 2022, 11:26 PM
Jdlrobson closed this task as Resolved.Jun 21 2022, 5:21 PM

I sent an email to Alex to remind him to review this at a later date.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits