Page MenuHomePhabricator

Read Builtin Definitions from `function-schemata/data/definitions`
Closed, ResolvedPublic

Description

function-orchestrator::src/builtins.js defines a large mapping from builtin ZIDs to ZObjects. We should read these objects from data/definitions, instead.

Some things to watch out for:

  • builtin implementations currently point to Z8/Functions instead of Z14/Implementations (as is done in data/definitions). We will actually desire this behavior in some sense: Z902 (as a string, passed as the identity of a builtin in Z14K4) should indeed point to a JavaScript function. What must change is how we process implementations: we should make sure that
{
  Z1K1: 'Z7',
  Z8K1: {
    ...
    Z8K4: [ 'Z902' ],
    ...
  },
  ...
}

works as expected.

  • the argument and return types of various builtin functions may be wrong in function-orchestrator (or, less likely, in function-schemata)

Event Timeline

Change 820107 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Correct some ZObject definitions.

https://gerrit.wikimedia.org/r/820107

Change 820107 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] definitions: Correct some pre-defined ZFunctions and ZImplementations

https://gerrit.wikimedia.org/r/820107

Change 820159 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0f79425)

https://gerrit.wikimedia.org/r/820159

Change 820159 abandoned by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0f79425)

Reason:

too many

https://gerrit.wikimedia.org/r/820159

Change 820159 restored by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0f79425)

https://gerrit.wikimedia.org/r/820159

Change 820159 abandoned by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0f79425)

Reason:

too many

https://gerrit.wikimedia.org/r/820159

Change 820411 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0f79425)

https://gerrit.wikimedia.org/r/820411

Change 820411 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (0f79425)

https://gerrit.wikimedia.org/r/820411

Change 819489 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] builtins: Read definitons from function-schemata where possible

https://gerrit.wikimedia.org/r/819489

Change 819489 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] builtins: Read definitions from function-schemata where possible

https://gerrit.wikimedia.org/r/819489

Change 820803 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (61e1542)

https://gerrit.wikimedia.org/r/820803

Change 820804 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (61e1542)

https://gerrit.wikimedia.org/r/820804

Change 820805 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (61e1542)

https://gerrit.wikimedia.org/r/820805

Change 820804 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (61e1542)

https://gerrit.wikimedia.org/r/820804

Change 820805 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (61e1542)

https://gerrit.wikimedia.org/r/820805

Change 820803 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (61e1542)

https://gerrit.wikimedia.org/r/820803

Change 822352 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Make list, pair, and map built-in functions instead of compositions.

https://gerrit.wikimedia.org/r/822352

Change 822352 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] definitions: Make list, pair, and map built-in functions instead of compositions

https://gerrit.wikimedia.org/r/822352

Change 823189 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823189

Change 823190 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823190

Change 823191 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823191

Change 823192 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823192

Change 823194 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823194

Change 823194 abandoned by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

Reason:

https://gerrit.wikimedia.org/r/823194

Change 823191 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823191

Change 823190 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823190

Change 823189 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823189

Change 823192 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823192