The libup patches
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DynamicPageListEngine/+/760205
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DataTable2/+/760174
were fail on phpcs errors in the current CI jobs.
This should normally not happen, because CI is testing with phpcs and avoid merging.
But this git repos receive direct pushed, which bypass gerrit and CI
For DynamicPageListEngine it is https://gerrit.wikimedia.org/g/mediawiki/extensions/DynamicPageListEngine/+/913bd0c07ad0513008f449eb1192b1c9554f951f
For DataTable2 it is https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/DataTable2/+/c152d0cf42d12e4f62e22377c3be343a940153f5
Bypass the tests of the CI pipeline brings in some problems for the auto-merge mode of libup. Libup auto-merge trival patch sets to reduce human interaction with the patch set.
A failing CI brings in some maintenance burden for it.
How to process with this situation?
Possible solution:
- Disable direct git pushes
- Exclude the repos from libup
- Keep status quo and hope someone fix the repo for the libup patch set
- Simplify CI jobs to merge without tests
- ...
It seems the setup with direct pushes is official support for extensions on gerrit. I have no idea how much extensions are affected.
This is only the aspect about direct pushes. There are other situation which can break CI and make it harder for libup to merge (force merges of patch set through gerrit with broken tests, hard deprecation in core/extensions of still used functions, remove of functions/table columns still used, version updates of unpinned dependency, changes in CI infratstructure, ...)