Namespace remaining Vector classes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Feb 7 2022, 10:36 PM

Description

SkinVector, SkinVectorLegacy and SkinVector22 are currently un-namespaced.

We'll use a class alias to support extensions that are checking the class is an instance of Vector.

	Subject	Repo	Branch	Lines +/-
	Namespace SkinVector* PHP classes	mediawiki/skins/Vector	master	+23 -12

Status	Assigned	Task
Open	None	T182943 Move namespaced extensions to use PSR-4 autoloading
Open	None	T278278 Adopt PSR-4 namespaces in WMF-deployed extensions/skins
Open	None	T278279 Namespace MW Tarball Bundled Extensions/Skins
Resolved	Reedy	T301204 Namespace remaining Vector classes

Change 760274 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/skins/Vector@master] Namespace rest of skin

Jdlrobson updated the task description. (Show Details)

Is dropping the class alias considered part of this task or is that less of a priority?

In T301204#7691765, @Jdlrobson wrote:

Is dropping the class alias considered part of this task or is that less of a priority?

We can cut it however you want.

T182943: Move namespaced extensions to use PSR-4 autoloading (and subtasks) is mostly about trying to get things moved over, with the result ofeventually reducing the size of $wgAutoloadClasses.

If we want to put a seperate task up for eventually removing those aliases at a later date when usages are fixed, that's fine by me.

There doesn't seem to be too many (but obviously, that also means it's non zero), so if we can clean up within a few months, I think that's a win

Change 760274 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Namespace SkinVector* PHP classes

Reedy closed this task as Resolved.Mar 4 2022, 6:06 PM

Reedy claimed this task.