Page MenuHomePhabricator

[regression] Link to homepage from Special:Contributions is unstyled
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable Growth features & log in with an account without any edits
  • Go to Special:Contributions page for the account

What happens?:
The link to Special:Homepage should be centered. On mobile, the default warning should not be shown.

What should have happened instead?:
There should be custom styling for the link to Special:Homepage

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Screen Shot 2022-02-07 at 2.41.05 PM.png (928×380 px, 57 KB)

Screen Shot 2022-02-07 at 2.47.27 PM.png (758×1,340 px, 100 KB)

Event Timeline

This regressed from the changes for T289060: Create single homepage module and single account creation related module to consolidate account-related modules. SpecialContributions.less was initially in ext.growthExperiments.Homepage.styles and was later moved to ext.growthExperiments.Account.styles.

With fix:

Screen Shot 2022-02-07 at 2.52.37 PM.png (1,442×386 px, 63 KB)

Special:MobileContributions (deprecated)

Screen Shot 2022-02-07 at 2.51.55 PM.png (756×1,346 px, 90 KB)

Screen Shot 2022-02-07 at 3.32.53 PM.png (762×1,334 px, 124 KB)

Change 760680 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add ext.growthExperiments.Account.styles for Special:Contributions with 0 edits

https://gerrit.wikimedia.org/r/760680

Etonkovidova subscribed.

Checked in betalabs - looks good. The comparison screenshots are below to check after the fix is deployed in wmf.22:

before the fix - wmf.21after the fix - testwiki wmf.22
Desktop
Screen Shot 2022-02-10 at 1.03.13 PM.png (1,888×858 px, 162 KB)
Screen Shot 2022-02-15 at 1.55.33 PM.png (1,271×450 px, 70 KB)
Mobile
Screen Shot 2022-02-10 at 1.04.19 PM.png (762×1,182 px, 136 KB)
Screen Shot 2022-02-15 at 1.55.09 PM.png (395×690 px, 79 KB)