Page MenuHomePhabricator

WikiEditor dialogs styled inconsistently across skins and wikis
Open, Needs TriagePublicBUG REPORT

Assigned To
None
Authored By
dom_walden
Feb 8 2022, 9:50 AM
Referenced Files
F34947653: wikieditor_insert_link_ar_beta.png
Feb 10 2022, 4:49 PM
F34945334: hewiki_wikieditor_minerva.png
Feb 8 2022, 10:04 AM
F34945332: arwiki_wikieditor_minerva.png
Feb 8 2022, 10:04 AM
F34945330: arwiki_wikieditor_vector.png
Feb 8 2022, 10:04 AM
F34945328: hewiki_wikieditor_vector.png
Feb 8 2022, 10:04 AM
F34945309: testwiki_wikieditor_css.png
Feb 8 2022, 9:50 AM
F34945297: testwiki_wikieditor.png
Feb 8 2022, 9:50 AM
F34945311: enwiki_wikieditor_css.png
Feb 8 2022, 9:50 AM

Description

What is the problem?

The styling of dialogs like "Insert link" and "Insert file" are inconsistent across skins and across wikis.

See below table comparing the "Insert link" dialog across Vector and Minerva on enwiki and testwiki. I believe only the top left image in the table is "correct" (that is how it has always appeared to me until now). Notice the other images have larger fonts and a different background colour:

WikiVectorMinerva
https://en.wikipedia.org
enwiki_wikieditor.png (519×319 px, 16 KB)
enwiki_wikieditor_minerva.png (526×408 px, 28 KB)
https://test.wikipedia.org (beta is the same)
testwiki_wikieditor.png (522×404 px, 24 KB)
testwiki_wikieditor_minerva.png (526×403 px, 24 KB)

(Both testwiki and enwiki had the same version of WikiEditor when I took those screenshots)

Compare also this part of the CSS on testwiki (as it appears on my Firefox):

testwiki_wikieditor_css.png (379×143 px, 16 KB)

To enwiki:

enwiki_wikieditor_css.png (381×196 px, 30 KB)

The .ui-widget-content class has different styling.

Steps to reproduce problem
  1. https://test.wikipedia.org/wiki/Acanthothecis_archeri?action=edit
  2. If necessary, switch to source editor
  3. Click the "Insert link" dialog (looks like part of a chain with tooltip "Link")
Environment

Browser: Firefox 91
Wiki(s): https://test.wikipedia.org MediaWiki 1.38.0-wmf.20 (a1e0247) 00:50, 1 February 2022.
Editor: WikiEditor 0.5.3 (259d826) 07:22, 31 January 2022.

Event Timeline

dom_walden renamed this task from WikiEditor dialogs styled differently on beta and testwiki to WikiEditor dialogs styled inconsistently across skins and wikis.Feb 8 2022, 9:50 AM

More inconsistencies, which may or may not be related to the above:

I am not sure about the styling and placement of the dialog on https://ar.wikipedia.beta.wmflabs.org:

wikieditor_insert_link_ar_beta.png (1,916×999 px, 134 KB)

It is not the same as it is on https://ar.wikipedia.org, on which it is placed in the centre of the screen.

happy5214 subscribed.

This appears to have been fixed on https://test.wikipedia.org/, at least for Vector. If this is still an issue, it's really a global jQuery UI issue rather than a WikiEditor issue, as the affected CSS is in core. (WikiEditor doesn't set any dialog background colors of its own.)