Page MenuHomePhabricator
Create Task
Maniphest T301234

Create basic form with text inputs
Closed, ResolvedPublic13 Estimated Story Points
Actions

Description

T298137: Lemma - Text Input
T298149: Lexical Category lookup - basic lexical category lookup
T298139: Lexeme Language Lookup - Basic language lookup

As kara
I want to see the completed form field for lexeme entry and be able to use input items
so that I can get a feel for how the page

a/c

  • text inputs for all fields
  • input items are used for the revelant fields
  • submit button exists, but does not yet function

Note:
submit functionality is included in a separate task: T298153

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+5 -0beta: Allow opening the alpha NewLexeme special page on beta-wikidatawiki
Customize query in gerrit

Related Objects
Search...

Event Timeline

karapayneWMDE created this task.Feb 8 2022, 11:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2022, 11:33 AM
karapayneWMDE updated the task description. (Show Details)Feb 8 2022, 11:35 AM
karapayneWMDE updated the task description. (Show Details)Feb 8 2022, 11:42 AM
karapayneWMDE set the point value for this task to 13.
ItamarWMDE moved this task from To Do to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 1) board.Feb 9 2022, 1:05 PM
Michael updated the task description. (Show Details)Feb 9 2022, 1:06 PM
Michael updated the task description. (Show Details)Feb 9 2022, 1:09 PM
ItamarWMDE added a subscriber: ItamarWMDE.Feb 9 2022, 1:49 PM

Task Breakdown Notes:

  • We will copy the content from the tickets mentioned in the description
  • We can start from the assumption that all we need is setup in order to use WiKit components
  • We have an empty App component to start with
  • We use WikitTaxtInputs and WikitButtons
  • Use an HTML form element
  • Each input should specify its name attribute, so that we could submit the form in the future, which will require a WiKit change
  • We add the button without the form action (we don't necessarily care if the page refreshes)
  • In case we notice any accessibility pitfalls in WiKit, the changes required for it would be in the scope of this task

Possible Action Plan:

  • Adapt WiKit Inputs to enable them to accept a native name attribute
  • Create control wrapper around each field and label (this will require the addition of unit tests)
    • ⇒ for separation of concerns and abstracting away display from data
    • ⇒ Easier to switch out WiKit with Codex
  • Add control fields and submit button to the form
  • Use WiKit tokens to lay out the fields: as specified in the Figma specs
ItamarWMDE moved this task from Parents / Waiting to To Do on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 1) board.Feb 9 2022, 1:49 PM
ItamarWMDE mentioned this in T298152: Inform about licensing.Feb 9 2022, 2:26 PM
Lydia_Pintscher added a project: Wikidata Lexicographical data.Feb 10 2022, 9:22 AM
Maintenance_bot added a project: Wikidata.Feb 10 2022, 9:45 AM
ItamarWMDE moved this task from To Do to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 1) board.Feb 14 2022, 10:28 AM
GitHub <noreply@github.com> mentioned this in rNLSP58e693090576: Add Lemma input (#28).Feb 15 2022, 12:50 PM
GitHub <noreply@github.com> mentioned this in rNLSP5b8a5cd91c96: Enforce class prefixes (#43).Feb 16 2022, 9:24 AM
Lucas_Werkmeister_WMDE closed subtask T301783: Add basic lexical category input as Resolved.Feb 16 2022, 1:55 PM
Lucas_Werkmeister_WMDE closed subtask T301894: Add basic language input as Resolved.Feb 17 2022, 12:31 PM
noarave closed subtask T301662: Create wrapper form and submit button as Resolved.Feb 17 2022, 12:33 PM
noarave closed subtask T301570: Create i18n plugin or directive as Resolved.
Celenduin mentioned this in rNLSP42e6aea6c82d: Implement overall layout for form.Feb 17 2022, 1:26 PM
Celenduin mentioned this in rNLSP16d1148c6111: Implement overall layout for form.Feb 17 2022, 2:10 PM
Celenduin mentioned this in rNLSPf8bf159aa2b5: Implement overall layout for form.Feb 17 2022, 2:51 PM
GitHub <noreply@github.com> mentioned this in rNLSP6577b1d17834: Layout for the form in context of the special page (#48).Feb 17 2022, 3:13 PM
Michael moved this task from Parents / Waiting to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 1) board.Feb 17 2022, 3:14 PM
Lydia_Pintscher added a subscriber: Lydia_Pintscher.Feb 17 2022, 7:17 PM

Where can I try it? :)

Sarai-WMDE added subscribers: Erdinc_Ciftci_WMDE, Sarai-WMDE.Feb 18 2022, 9:40 AM

The state of the form in main can be checked via this link: https://d3002abfe74c2432e92dcb465ca996082011--new-lexeme-special-page.netlify.app/

Pinging @Erdinc_Ciftci_WMDE

gerritbot added a comment.Feb 18 2022, 10:13 AM

Change 763703 had a related patch set uploaded (by Michael Große; author: Michael Große):

[operations/mediawiki-config@master] beta: Allow opening the alpha NewLexeme special page on beta-wikidatawiki

https://gerrit.wikimedia.org/r/763703

gerritbot added a project: Patch-For-Review.Feb 18 2022, 10:13 AM
Michael added a subscriber: Michael.Feb 18 2022, 10:17 AM
In T301234#7720614, @Sarai-WMDE wrote:

The state of the form in main can be checked via this link: https://d3002abfe74c2432e92dcb465ca996082011--new-lexeme-special-page.netlify.app/

Pinging @Erdinc_Ciftci_WMDE

Yes! And the mediawiki config change above should enable it on beta. We can deploy that on Monday

Lydia_Pintscher added a comment.Feb 18 2022, 12:03 PM

\o/
Leaving this open for the beta patch still but looking good.

gerritbot added a comment.Feb 22 2022, 11:18 AM

Change 763703 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Allow opening the alpha NewLexeme special page on beta-wikidatawiki

https://gerrit.wikimedia.org/r/763703

Stashbot added a comment.Feb 22 2022, 11:20 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-22T11:20:46Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:763703|beta: Allow opening the alpha NewLexeme special page on beta-wikidatawiki (T301234)]] (Beta only) (duration: 00m 48s)

Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.Feb 22 2022, 11:21 AM

https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha is now running, but we haven’t yet updated WikibaseLexeme with a version of the submodule that includes the basic form.

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2022, 12:10 PM
Lydia_Pintscher closed this task as Resolved.Feb 23 2022, 4:09 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Test (Verification) to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 1) board.

\o/

Lydia_Pintscher closed subtask T301446: Provide Branch Hosting for GitHub repo with Netlify as Resolved.Feb 23 2022, 4:10 PM
Erdinc_Ciftci_WMDE added a comment.Feb 24 2022, 8:56 AM
In T301234#7720614, @Sarai-WMDE wrote:

The state of the form in main can be checked via this link: https://d3002abfe74c2432e92dcb465ca996082011--new-lexeme-special-page.netlify.app/

Pinging @Erdinc_Ciftci_WMDE

@Sarai-WMDE thanks for this ping, I had a look and saved this to regularly check.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL