Page MenuHomePhabricator

Create basic form with text inputs
Closed, ResolvedPublic13 Estimated Story Points

Description

T298137: Lemma - Text Input
T298149: Lexical Category lookup - basic lexical category lookup
T298139: Lexeme Language Lookup - Basic language lookup

As kara
I want to see the completed form field for lexeme entry and be able to use input items
so that I can get a feel for how the page

a/c

  • text inputs for all fields
  • input items are used for the revelant fields
  • submit button exists, but does not yet function

Note:
submit functionality is included in a separate task: T298153

Event Timeline

karapayneWMDE set the point value for this task to 13.

Task Breakdown Notes:

  • We will copy the content from the tickets mentioned in the description
  • We can start from the assumption that all we need is setup in order to use WiKit components
  • We have an empty App component to start with
  • We use WikitTaxtInputs and WikitButtons
  • Use an HTML form element
  • Each input should specify its name attribute, so that we could submit the form in the future, which will require a WiKit change
  • We add the button without the form action (we don't necessarily care if the page refreshes)
  • In case we notice any accessibility pitfalls in WiKit, the changes required for it would be in the scope of this task

Possible Action Plan:

  • Adapt WiKit Inputs to enable them to accept a native name attribute
  • Create control wrapper around each field and label (this will require the addition of unit tests)
    • ⇒ for separation of concerns and abstracting away display from data
    • ⇒ Easier to switch out WiKit with Codex
  • Add control fields and submit button to the form
  • Use WiKit tokens to lay out the fields: as specified in the Figma specs

Change 763703 had a related patch set uploaded (by Michael Große; author: Michael Große):

[operations/mediawiki-config@master] beta: Allow opening the alpha NewLexeme special page on beta-wikidatawiki

https://gerrit.wikimedia.org/r/763703

The state of the form in main can be checked via this link: https://d3002abfe74c2432e92dcb465ca996082011--new-lexeme-special-page.netlify.app/

Pinging @Erdinc_Ciftci_WMDE

Yes! And the mediawiki config change above should enable it on beta. We can deploy that on Monday

\o/
Leaving this open for the beta patch still but looking good.

Change 763703 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Allow opening the alpha NewLexeme special page on beta-wikidatawiki

https://gerrit.wikimedia.org/r/763703

Mentioned in SAL (#wikimedia-operations) [2022-02-22T11:20:46Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:763703|beta: Allow opening the alpha NewLexeme special page on beta-wikidatawiki (T301234)]] (Beta only) (duration: 00m 48s)

https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha is now running, but we haven’t yet updated WikibaseLexeme with a version of the submodule that includes the basic form.

The state of the form in main can be checked via this link: https://d3002abfe74c2432e92dcb465ca996082011--new-lexeme-special-page.netlify.app/

Pinging @Erdinc_Ciftci_WMDE

@Sarai-WMDE thanks for this ping, I had a look and saved this to regularly check.