Page MenuHomePhabricator

Handle deprecation of Serializable interface in WikibaseLexeme
Closed, ResolvedPublic3 Estimated Story Points

Description

WikibaseLexeme  (2 usages found)
    src  (2 usages found)
        Domain  (2 usages found)
            Model  (2 usages found)
                LexemeId.php  (2 usages found)
                    56 * @see Serializable::serialize
                    65 * @see Serializable::unserialize

LexemeId needs to implement the new magic methods __serialize and __unserialize so it can be serialized without warnings in PHP 8.1; compare the similar patches in Wikibase (especially for the ItemId class).

Event Timeline

These can only be addressed once T305785 is fixed.

Sprint 7 planinng: during the task breakdown, please break down the remaining work into a child task and estimate it

No work on this task has been done yet, so we don’t need a separate task for the remaining work.

Moving to the Waiting column because it’s blocked on T305785 and T318918. Once those are done, we estimate this at 3 points.

Lucas_Werkmeister_WMDE added a subscriber: hoo.

I think this is ready to go now, and I’ll go ahead and steal it from Marius :)

Change 840101 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to entity ID classes

https://gerrit.wikimedia.org/r/840101

Change 840102 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to diff (op) classes

https://gerrit.wikimedia.org/r/840102

Change 840101 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to entity ID classes

https://gerrit.wikimedia.org/r/840101

Change 840102 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to diff (op) classes

https://gerrit.wikimedia.org/r/840102

I think we can just close this, and reopen it if we notice any deprecation errors from WikibaseLexeme once everything else is cleaned up.