Page MenuHomePhabricator
Create Task
Maniphest T301248

Handle deprecation of Serializable interface in WikibaseLexeme
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

WikibaseLexeme  (2 usages found)
    src  (2 usages found)
        Domain  (2 usages found)
            Model  (2 usages found)
                LexemeId.php  (2 usages found)
                    56 * @see Serializable::serialize
                    65 * @see Serializable::unserialize

LexemeId needs to implement the new magic methods __serialize and __unserialize so it can be serialized without warnings in PHP 8.1; compare the similar patches in Wikibase (especially for the ItemId class).

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add __serialize/__unserialize to diff (op) classesLucas Werkmeister (WMDE)mediawiki/extensions/WikibaseLexememaster+45 -48
Add __serialize/__unserialize to entity ID classesLucas Werkmeister (WMDE)mediawiki/extensions/WikibaseLexememaster+37 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Feb 8 2022, 1:58 PM
Reedy updated the task description. (Show Details)Feb 8 2022, 2:00 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Feb 8 2022, 2:03 PM
Lucas_Werkmeister_WMDE mentioned this in T301249: Handle deprecation of Serializable interface in Wikibase.Feb 8 2022, 5:04 PM
hoo claimed this task.Mar 24 2022, 12:08 PM
hoo added a project: Wikidata-Campsite (Team A Hearth 🏰🔥).
hoo moved this task from Incoming to Doing on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.
• Manuel added a subtask: T305785: Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization.Aug 2 2022, 12:44 PM
• Manuel edited projects, added: [Archived]Wikidata Dev Team (Sprint-∞); removed: Wikidata-Campsite (Team A Hearth 🏰🔥).Aug 3 2022, 1:25 PM
• Manuel moved this task from Parents/Waiting to Doing on the [Archived]Wikidata Dev Team (Sprint-∞) board.
hoo added a comment.Sep 16 2022, 10:29 PM

These can only be addressed once T305785 is fixed.

• karapayneWMDE moved this task from Doing to Peer Review on the [Archived]Wikidata Dev Team (Sprint-∞) board.Oct 4 2022, 10:01 AM
• karapayneWMDE moved this task from Peer Review to Doing on the [Archived]Wikidata Dev Team (Sprint-∞) board.
• karapayneWMDE subscribed.Oct 4 2022, 10:20 AM

Sprint 7 planinng: during the task breakdown, please break down the remaining work into a child task and estimate it

Lucas_Werkmeister_WMDE set the point value for this task to 3.Oct 5 2022, 9:11 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Parents/Waiting on the [Archived]Wikidata Dev Team (Sprint-∞) board.
Lucas_Werkmeister_WMDE subscribed.

No work on this task has been done yet, so we don’t need a separate task for the remaining work.

Moving to the Waiting column because it’s blocked on T305785 and T318918. Once those are done, we estimate this at 3 points.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 5 2022, 9:12 AM
Lucas_Werkmeister_WMDE claimed this task.Oct 7 2022, 10:26 AM
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Doing on the [Archived]Wikidata Dev Team (Sprint-∞) board.
Lucas_Werkmeister_WMDE added a subscriber: hoo.

I think this is ready to go now, and I’ll go ahead and steal it from Marius :)

gerritbot added a comment.Oct 7 2022, 10:57 AM

Change 840101 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to entity ID classes

https://gerrit.wikimedia.org/r/840101

gerritbot added a project: Patch-For-Review.Oct 7 2022, 10:57 AM

Change 840102 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to diff (op) classes

https://gerrit.wikimedia.org/r/840102

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the [Archived]Wikidata Dev Team (Sprint-∞) board.Oct 7 2022, 11:19 AM
gerritbot added a comment.Oct 7 2022, 11:32 AM

Change 840101 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to entity ID classes

https://gerrit.wikimedia.org/r/840101

gerritbot added a comment.Oct 7 2022, 11:37 AM

Change 840102 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add __serialize/__unserialize to diff (op) classes

https://gerrit.wikimedia.org/r/840102

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 7 2022, 12:00 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Tech Verification on the [Archived]Wikidata Dev Team (Sprint-∞) board.Oct 7 2022, 12:24 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2022, 12:30 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 13 2022, 10:19 AM
Lucas_Werkmeister_WMDE moved this task from Tech Verification to Our work done on the [Archived]Wikidata Dev Team (Sprint-∞) board.

I think we can just close this, and reopen it if we notice any deprecation errors from WikibaseLexeme once everything else is cleaned up.

Lucas_Werkmeister_WMDE closed subtask T305785: Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization as Resolved.Oct 13 2022, 10:19 AM
• karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the [Archived]Wikidata Dev Team (Sprint-∞) board.Oct 18 2022, 9:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits