Page MenuHomePhabricator
Create Task
Maniphest T301249

Handle deprecation of Serializable interface in Wikibase
Closed, ResolvedPublic
Actions

Description

Wikibase  (30 usages found)
    lib  (30 usages found)
        packages  (30 usages found)
            wikibase  (30 usages found)
                changes  (8 usages found)
                    src  (8 usages found)
                        EntityDiffChangedAspects.php  (4 usages found)
                            6 use Serializable;
                            18 class EntityDiffChangedAspects implements Serializable {
                            139 * @see Serializable::serialize
                            148 * @see Serializable::unserialize
                        RepoRevisionIdentifier.php  (4 usages found)
                            7 use Serializable;
                            17 class RepoRevisionIdentifier implements Serializable {
                            79 * @see Serializable::serialize
                            88 * @see Serializable::unserialize
                data-model  (22 usages found)
                    src  (20 usages found)
                        Entity  (8 usages found)
                            EntityId.php  (2 usages found)
                                5 use Serializable;
                                10 interface EntityId extends Serializable {
                            EntityIdValue.php  (2 usages found)
                                27 * @see Serializable::serialize
                                40 * @see Serializable::unserialize
                            ItemId.php  (2 usages found)
                                63 * @see Serializable::serialize
                                74 * @see Serializable::unserialize
                            NumericPropertyId.php  (2 usages found)
                                59 * @see Serializable::serialize
                                68 * @see Serializable::unserialize
                        Snak  (8 usages found)
                            PropertyValueSnak.php  (2 usages found)
                                50 * @see Serializable::serialize
                                61 * @see Serializable::unserialize
                            Snak.php  (2 usages found)
                                5 use Serializable;
                                17 interface Snak extends Serializable, PropertyIdProvider {
                            SnakList.php  (2 usages found)
                                268 * @see Serializable::serialize
                                277 * @see Serializable::unserialize
                            SnakObject.php  (2 usages found)
                                96 * @see Serializable::serialize
                                107 * @see Serializable::unserialize
                        ReferenceList.php  (4 usages found)
                            9 use Serializable;
                            27 class ReferenceList implements Countable, IteratorAggregate, Serializable {
                            225 * @see Serializable::serialize
                            256 * @see Serializable::unserialize
                    tests  (2 usages found)
                        fixtures  (2 usages found)
                            CustomEntityId.php  (2 usages found)
                                16 * @see Serializable::serialize
                                25 * @see Serializable::unserialize

Details

SubjectRepoBranchLines +/-
Declare compatibility with data-values/number ^0.12.3mediawiki/extensions/WikibaseQualityConstraintsREL1_39+6 -0
FederatedPropertyId: Add __serialize()/__unserialize()mediawiki/extensions/WikibaseREL1_39+8 -0
Add __serialize() and __unserialize() to EntityIdmediawiki/extensions/WikibaseREL1_39+21 -0
Drop compatibility with older data-values versionsmediawiki/extensions/WikibaseREL1_39+21 -13
DataModel\Entity: Add __serialize/__unserialize for EntityIdsmediawiki/extensions/WikibaseREL1_39+146 -10
Add __serialize() and __unserialize() to EntityIdmediawiki/extensions/Wikibasemaster+21 -0
Make a few tests more compatible with PHP 8.1mediawiki/extensions/Wikibasemaster+8 -8
Use BooleanValue in CommonsMediaValueNormalizerTestmediawiki/extensions/Wikibasemaster+2 -2
Drop compatibility with older data-values versionsmediawiki/extensions/Wikibasemaster+15 -40
FederatedPropertyId: Add __serialize()/__unserialize()mediawiki/extensions/Wikibasemaster+8 -0
Update data-values/*mediawiki/vendormaster+426 -213
Update data-values versions in composer.jsonmediawiki/extensions/Wikibasemaster+49 -16
Declare compatibility with data-values/number ^0.12.3mediawiki/extensions/WikibaseQualityConstraintsmaster+1 -1
DM: Add __(un)serialize to Snak (and implementations)mediawiki/extensions/Wikibasemaster+25 -6
DM: Add abstract __(un)serialize to SerializableEntityIdmediawiki/extensions/Wikibasemaster+5 -1
MediaInfoId: Add (return) type hints to __(un)serializemediawiki/extensions/WikibaseMediaInfomaster+2 -2
Use MockBuilder::getMockForAbstractClass for SerializableEntityIdmediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
DataModel\Entity: Add __serialize/__unserialize for EntityIdsmediawiki/extensions/Wikibasemaster+146 -10
Implement __serialize/__unserialize for PHP 8.1 supportmediawiki/extensions/Wikibasemaster+30 -18
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Feb 8 2022, 1:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2022, 1:59 PM
Reedy updated the task description. (Show Details)Feb 8 2022, 2:01 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Feb 8 2022, 2:03 PM
Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.Feb 8 2022, 5:04 PM

I’d like to think we don’t rely on serialize() of Wikibase entity IDs anywhere, but that’s probably a fool’s hope. (E.g., I believe the caching layer uses PHP serialization, and we probably put entity ID objects into and out of caches somewhere, even if strings would be cleaner.)

The good news that this should be reasonably straightforward, the serialization is just a string and the deserialization just needs to reconstruct a small bit of internal state afterwards. (I believe this is true for all the entity ID types we have, so including T301248 and T301223.)

Lucas_Werkmeister_WMDE added a comment.Feb 8 2022, 5:06 PM

…And I should learn to read the full task description, this one isn’t only about entity IDs. 🤦

But from a quick look through them, it seems like the other affected classes also don’t have super complicated serialization methods. In fact the new magic method interface should be more easy to implement, since we can directly return arrays in some cases instead of wrapping them in JSON.

Reedy added a comment.Feb 8 2022, 7:43 PM
In T301249#7693897, @Lucas_Werkmeister_WMDE wrote:

…And I should learn to read the full task description, this one isn’t only about entity IDs. 🤦

But from a quick look through them, it seems like the other affected classes also don’t have super complicated serialization methods. In fact the new magic method interface should be more easy to implement, since we can directly return arrays in some cases instead of wrapping them in JSON.

Sounds pretty much like what I did for the couple of patches to numerous classes in MW Core.

Make the new __ methods handle the array version, keep the old non __ prefixed versions with any special handling (turning to strings, or whatever else) and make them call the __ versions

https://gerrit.wikimedia.org/r/c/756964
https://gerrit.wikimedia.org/r/c/758800

And if the tests are about right, you should know whether your changes are correct ;D

Lucas_Werkmeister_WMDE added a comment.Feb 9 2022, 12:27 PM
In T301249#7694774, @Reedy wrote:

And if the tests are about right, you should know whether your changes are correct ;D

And thankfully we already run php74 in gate-and-submit, so at least one job should cover the new methods 😌

gerritbot added a comment.Feb 12 2022, 8:25 PM

Change 762094 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Implement __serialize/__unserialize for PHP 8.1 support

https://gerrit.wikimedia.org/r/762094

gerritbot added a project: Patch-For-Review.Feb 12 2022, 8:25 PM
gerritbot added a comment.Feb 14 2022, 9:57 AM

Change 762094 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Implement __serialize/__unserialize for PHP 8.1 support

https://gerrit.wikimedia.org/r/762094

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 14 2022, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 14 2022, 10:10 AM
hoo claimed this task.Mar 24 2022, 12:08 PM
hoo added a project: Wikidata-Campsite (Team A Hearth 🏰🔥).
hoo moved this task from Incoming to Doing on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.
gerritbot added a comment.Mar 24 2022, 2:51 PM

Change 773521 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] DataModel\Entity: Add __serialize/__unserialize for EntityIds

https://gerrit.wikimedia.org/r/773521

gerritbot added a project: Patch-For-Review.Mar 24 2022, 2:51 PM
hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Mar 24 2022, 2:53 PM
Lucas_Werkmeister_WMDE added a comment.EditedApr 5 2022, 2:02 PM

I think the Diff package, used by Wikibase, could also be included in this task; somebody already uploaded a pull request for it: https://github.com/wmde/Diff/pull/128

(Edit: See also the more narrowly scoped PR https://github.com/wmde/Diff/pull/129)

Manuel removed projects: Patch-For-Review, MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Jun 14 2022, 8:13 AM
Manuel added a subscriber: Manuel.

Hi @hoo are you still working on this?

Manuel edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata-Campsite (Team A Hearth 🏰🔥).Aug 2 2022, 9:34 AM
Manuel moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
Michael added a subscriber: Michael.Aug 31 2022, 9:01 AM
hoo added a comment.Sep 16 2022, 10:28 PM

As far as I can see, all remaining issues can only be addressed once T305785 is fixed.

Jdforrester-WMF added a parent task: T319065: All Wikimedia production extensions and skins must support PHP 8.1.Sep 30 2022, 6:14 PM
gerritbot added a comment.Oct 7 2022, 10:00 AM

Change 773521 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DataModel\Entity: Add __serialize/__unserialize for EntityIds

https://gerrit.wikimedia.org/r/773521

Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata Dev Team (Sprint-∞) board.Oct 10 2022, 3:32 PM

Moving back to Doing, AFAICT there’s nothing to review here at the moment. I think the remaining open part is the DataValues library.

Lucas_Werkmeister_WMDE added a parent task: T319219: Wikibase gives deprecated warnings on php 8.1.Oct 12 2022, 12:46 PM
Lucas_Werkmeister_WMDE closed subtask T305785: Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization as Resolved.Oct 13 2022, 10:19 AM
gerritbot added a comment.Oct 13 2022, 11:17 AM

Change 842427 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] DM: Add abstract __(un)serialize to SerializableEntityId

https://gerrit.wikimedia.org/r/842427

gerritbot added a project: Patch-For-Review.Oct 13 2022, 11:17 AM

Change 842428 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] DM: Add __(un)serialize to Snak (and implementations)

https://gerrit.wikimedia.org/r/842428

gerritbot added a comment.Oct 13 2022, 11:26 AM

Change 842434 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseMediaInfo@master] MediaInfoId: Add (return) type hints to __(un)serialize

https://gerrit.wikimedia.org/r/842434

gerritbot added a comment.Oct 13 2022, 11:49 AM

Change 842436 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseQualityConstraints@master] Use MockBuilder::getMockForAbstractClass for SerializableEntityId

https://gerrit.wikimedia.org/r/842436

gerritbot added a comment.Oct 13 2022, 12:32 PM

Change 842436 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Use MockBuilder::getMockForAbstractClass for SerializableEntityId

https://gerrit.wikimedia.org/r/842436

gerritbot added a comment.Oct 13 2022, 12:32 PM

Change 842434 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] MediaInfoId: Add (return) type hints to __(un)serialize

https://gerrit.wikimedia.org/r/842434

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 13 2022, 1:00 PM
hoo moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Oct 13 2022, 7:36 PM
gerritbot added a comment.Oct 14 2022, 9:14 AM

Change 842427 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DM: Add abstract __(un)serialize to SerializableEntityId

https://gerrit.wikimedia.org/r/842427

gerritbot added a comment.Oct 14 2022, 9:14 AM

Change 842428 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DM: Add __(un)serialize to Snak (and implementations)

https://gerrit.wikimedia.org/r/842428

Lucas_Werkmeister_WMDE added a comment.Oct 14 2022, 11:12 AM

DataValues pull requests:

(Some of them need more work before CI passes.)

gerritbot added a comment.Oct 21 2022, 3:07 PM

Change 845589 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Declare compatibility with data-values/number ^0.12.0

https://gerrit.wikimedia.org/r/845589

gerritbot added a comment.Oct 21 2022, 3:08 PM

Change 845590 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Declare compatibility with data-values/number ^0.12.0

https://gerrit.wikimedia.org/r/845590

gerritbot added a comment.Oct 24 2022, 10:56 AM

Change 848265 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Drop compatibility with older data-values versions

https://gerrit.wikimedia.org/r/848265

gerritbot added a comment.Oct 24 2022, 1:54 PM

Change 848346 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/vendor@master] Update data-values/*

https://gerrit.wikimedia.org/r/848346

gerritbot added a comment.Oct 25 2022, 11:37 AM

Change 845589 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update data-values versions in composer.json

https://gerrit.wikimedia.org/r/845589

gerritbot added a comment.Oct 25 2022, 11:37 AM

Change 845590 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Declare compatibility with data-values/number ^0.12.3

https://gerrit.wikimedia.org/r/845590

Lucas_Werkmeister_WMDE mentioned this in T320513: 1.40.0-wmf.8 deployment blockers.Oct 25 2022, 11:41 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 25 2022, 12:00 PM
gerritbot added a comment.Oct 25 2022, 12:16 PM

Change 848346 merged by jenkins-bot:

[mediawiki/vendor@master] Update data-values/*

https://gerrit.wikimedia.org/r/848346

gerritbot added a comment.Oct 27 2022, 3:46 PM

Change 850189 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] FederatedPropertyId: Add __serialize()/__unserialize()

https://gerrit.wikimedia.org/r/850189

Lucas_Werkmeister_WMDE mentioned this in T319219: Wikibase gives deprecated warnings on php 8.1.Oct 27 2022, 3:46 PM
gerritbot added a comment.Oct 28 2022, 9:26 AM

Change 850189 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FederatedPropertyId: Add __serialize()/__unserialize()

https://gerrit.wikimedia.org/r/850189

gerritbot added a comment.Nov 1 2022, 9:29 AM

Change 848265 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Drop compatibility with older data-values versions

https://gerrit.wikimedia.org/r/848265

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Nov 1 2022, 10:00 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata Dev Team (Sprint-∞) board.Nov 1 2022, 11:26 AM

Moving back to doing; this PHP 8.1 CI log has two Serializable-related deprecation warnings left:

24) Wikibase\Repo\Tests\Normalization\CommonsMediaValueNormalizerTest::testNormalize_badType
Mock_DataValue_5fa3bfea implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)

Deprecated: Mock_EntityId_c95bc3e8 implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /workspace/src/vendor/phpunit/phpunit/src/Framework/MockObject/MockClass.php(51) : eval()'d code on line 3

That second one isn’t reported as belonging to any particular test case, so I guess we just need to grep for calls like $this->createMock( EntityId::class ). Shouldn’t require any more library updates, though – I think all the DataValues stuff is done at last.

Lucas_Werkmeister_WMDE added a comment.Nov 1 2022, 3:03 PM

Correction: there might be more Serializable-related warnings, because the above job failed before it ran the DB tests. (But it at least finished running the non-DB tests and reported all the errors in there, instead of crashing partway through as it used to.)

git grep 'createMock.*EntityId:' finds 16 occurrences. I think a convenient way to make all of them work would be to add __serialize() / __unserialize() methods to the EntityId interface, so that PHPUnit will mock them automatically. (This would be a breaking change, but the data model RELEASE-NOTES.md already list the in-progress version as a major version update (10.0.0) with breaking changes.) I wonder if this would be acceptable?

gerritbot added a comment.Nov 1 2022, 3:06 PM

Change 851651 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use BooleanValue in CommonsMediaValueNormalizerTest

https://gerrit.wikimedia.org/r/851651

gerritbot added a comment.Nov 2 2022, 9:09 AM

Change 851651 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use BooleanValue in CommonsMediaValueNormalizerTest

https://gerrit.wikimedia.org/r/851651

gerritbot added a comment.Nov 2 2022, 12:01 PM

Change 852162 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Wikibase@master] Make a few tests more compatible with PHP 8.1

https://gerrit.wikimedia.org/r/852162

gerritbot added a comment.Nov 2 2022, 12:28 PM

Change 852162 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make a few tests more compatible with PHP 8.1

https://gerrit.wikimedia.org/r/852162

gerritbot added a comment.Nov 4 2022, 1:37 PM

Change 853286 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add __serialize() and __unserialize() to EntityId

https://gerrit.wikimedia.org/r/853286

Lucas_Werkmeister_WMDE added a comment.Nov 4 2022, 1:38 PM

git grep 'createMock.*EntityId:' finds 16 occurrences. I think a convenient way to make all of them work would be to add __serialize() / __unserialize() methods to the EntityId interface, so that PHPUnit will mock them automatically. (This would be a breaking change, but the data model RELEASE-NOTES.md already list the in-progress version as a major version update (10.0.0) with breaking changes.) I wonder if this would be acceptable?

Did that in the above change, since I haven’t heard any complaints about it yet. Let’s see if CI is happy with it.

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Nov 7 2022, 11:59 AM
gerritbot added a comment.Nov 8 2022, 10:46 AM

Change 853286 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add __serialize() and __unserialize() to EntityId

https://gerrit.wikimedia.org/r/853286

Lucas_Werkmeister_WMDE moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Nov 8 2022, 10:48 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 10 2022, 10:29 AM
Lucas_Werkmeister_WMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.

PHP 8.1 is voting in gate-and-submit now, so I think we can be confident that this is done.

GreenReaper mentioned this in T322467: Wikibase test failures on REL1_39.Nov 10 2022, 12:20 PM
karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Dec 20 2022, 6:52 PM
gerritbot added a comment.Jan 16 2023, 11:13 PM

Change 880548 had a related patch set uploaded (by Addshore; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] FederatedPropertyId: Add __serialize()/__unserialize()

https://gerrit.wikimedia.org/r/880548

gerritbot added a comment.Jan 16 2023, 11:13 PM

Change 880549 had a related patch set uploaded (by Addshore; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Add __serialize() and __unserialize() to EntityId

https://gerrit.wikimedia.org/r/880549

gerritbot added a comment.Jan 16 2023, 11:13 PM

Change 880550 had a related patch set uploaded (by Addshore; author: Hoo man):

[mediawiki/extensions/Wikibase@REL1_39] DataModel\Entity: Add __serialize/__unserialize for EntityIds

https://gerrit.wikimedia.org/r/880550

gerritbot added a comment.Jan 16 2023, 11:13 PM

Change 880551 had a related patch set uploaded (by Addshore; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_39] Drop compatibility with older data-values versions

https://gerrit.wikimedia.org/r/880551

gerritbot added a comment.Jan 17 2023, 9:42 PM

Change 880923 had a related patch set uploaded (by Addshore; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@REL1_39] Declare compatibility with data-values/number ^0.12.3

https://gerrit.wikimedia.org/r/880923

gerritbot added a comment.Feb 6 2023, 11:58 PM

Change 880550 abandoned by Addshore:

[mediawiki/extensions/Wikibase@REL1_39] DataModel\Entity: Add __serialize/__unserialize for EntityIds

Reason:

https://gerrit.wikimedia.org/r/880550

gerritbot added a comment.Feb 6 2023, 11:58 PM

Change 880551 abandoned by Addshore:

[mediawiki/extensions/Wikibase@REL1_39] Drop compatibility with older data-values versions

Reason:

https://gerrit.wikimedia.org/r/880551

gerritbot added a comment.Feb 6 2023, 11:58 PM

Change 880549 abandoned by Addshore:

[mediawiki/extensions/Wikibase@REL1_39] Add __serialize() and __unserialize() to EntityId

Reason:

https://gerrit.wikimedia.org/r/880549

gerritbot added a comment.Feb 6 2023, 11:58 PM

Change 880548 abandoned by Addshore:

[mediawiki/extensions/Wikibase@REL1_39] FederatedPropertyId: Add __serialize()/__unserialize()

Reason:

https://gerrit.wikimedia.org/r/880548

gerritbot added a comment.Feb 6 2023, 11:59 PM

Change 880923 abandoned by Addshore:

[mediawiki/extensions/WikibaseQualityConstraints@REL1_39] Declare compatibility with data-values/number ^0.12.3

Reason:

https://gerrit.wikimedia.org/r/880923

Lucas_Werkmeister_WMDE mentioned this in T345856: Remove Serializable interface from EntityId.Sep 7 2023, 2:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL