Special:MyLanguage redirects to the translation original if the user language matches the content language, even if they differ from the page language
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Kaganer
	Feb 9 2022, 7:02 AM

Description

Special:MyLanguage redirects to the translation original (i.e. the page with no language suffix) if the user language is the same as the site content language, even if that particular translation original has another language. In this case, it should redirect to the /en subpage (assuming that the site content language is English) if that exists.

List of steps to reproduce (step by step, including full links if applicable):

For the page Commons:Gara_e_fotografisë_së_ushqimit_tradicional_shqiptar_-_2022 on Commons the page language was set to sq (Albanian); this page was marked for translation
Switch Your interface language to English
Click by link Special:MyLanguage/Commons:Gara_e_fotografisë_së_ushqimit_tradicional_shqiptar_-_2022

What happens?:

We got on base page (Albanian).

What should have happened instead?:

We should be got on translated /en subpage.

Details

	Subject	Repo	Branch	Lines +/-
	SpecialMyLanguage: Take content language of the base page into account	mediawiki/core	master	+21 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Func	T301316 Special:MyLanguage redirects to the translation original if the user language matches the content language, even if they differ from the page language
		Resolved		Florian	T121834 Special:MyLanguage doesn't work, if page language was changed

Event Timeline

Kaganer created this task.Feb 9 2022, 7:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2022, 7:02 AM

Kaganer added a subscriber: Nikerabbit.Feb 9 2022, 7:17 AM

Kaganer updated the task description. (Show Details)Feb 9 2022, 7:20 AM

Special:MyLanguage is part of MediaWiki core (rMW includes/specials/SpecialMyLanguage.php), not the Translate extension (since T68762).

By the way, are you sure Nikerabbit is happy that you subscribed him on this task? It makes the impression you want him personally to fix this bug, even though there are several other software engineers in the Language team.

Tacsipacsi renamed this task from Special:MyLanguage generate irrelevant links in some case to Special:MyLanguage redirects to the translation original if the user language matches the content language, even if they differ from the page language.Feb 9 2022, 11:39 AM

Tacsipacsi updated the task description. (Show Details)

Change 769458 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialMyLanguage: Take content language of the base page into account

https://gerrit.wikimedia.org/r/769458

gerritbot added a project: Patch-For-Review.Mar 9 2022, 3:39 PM

Func mentioned this in T278639: Add language redirects or backwards fallbacks for Special:MyLanguage.Mar 9 2022, 3:41 PM

Func subscribed.

Winston_Sung subscribed.Mar 9 2022, 3:44 PM

Base subscribed.Apr 7 2022, 10:31 AM

Winston_Sung changed the task status from Open to In Progress.Apr 7 2022, 10:32 AM

Winston_Sung assigned this task to Func.

even though there are several other software engineers in the Language team.

(While Language team is one of the more stable ones, usually WMF teams and departments are rewamped all the time (every couple of years or so) and sometimes you just remember that a particular person has been working on this or that thing at some point. E.g. I poke Amire80 about CX issues sometimes like this. Not sure if that is what was Kaganer's motivation though, just an observation as a community member)

By the way, are you sure Nikerabbit is happy that you subscribed him on this task? It makes the impression you want him personally to fix this bug, even though there are several other software engineers in the Language team.

I thought I understood the difference between "Assigned to" and "Subscribers" quite clearly. For me, the addition of "Subscriber" is a call "look, it seems to me that this is important / interesting for you." When me is added to subscribers by other users, I understand it this way and feel gratitude. If I was added by mistake, I just unsubscribe.

Since I have direct contact with Niklas (at least in the translatewiki.net telegram chat), he can always warn me if I'm doing something wrong. Niklas has known me for 14 years, through wiki work, and I really hope that he will not be shy in expressions.

Pols12 subscribed.May 26 2022, 4:55 PM

Change 769458 merged by jenkins-bot:

[mediawiki/core@master] SpecialMyLanguage: Take content language of the base page into account

https://gerrit.wikimedia.org/r/769458

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2022, 2:31 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 5 2022, 3:00 PM

Patch merged.

Winston_Sung added a subtask: T121834: Special:MyLanguage doesn't work, if page language was changed.Mar 27 2023, 11:22 AM