Page MenuHomePhabricator
Create Task
Maniphest T301346

Searching for special pages with REST API: The given PageIdentity Special:AbuseFilter does not represent a proper page
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable new Vector header.
  • Type Special:A in the search box

What happens?:

  • Fatal errors in the logs
[2022-02-09T13:53:03.369483+00:00] exception.ERROR: [c9a135346b1aa8bf78509849] /w/rest.php/v1/search/title?q=Special%3AA&limit=10   MediaWiki\Page\PageAssertionException: The given PageIdentity Special:AbuseFilter does not represent a proper page {"exception":"[object] (MediaWiki\\Page\\PageAssertionException(code: 0): The given PageIdentity Special:AbuseFilter does not represent a proper page at /srv/mediawiki/workdir/includes/page/WikiPageFactory.php:59)
[stacktrace]
#0 /srv/mediawiki/workdir/includes/page/RedirectStore.php(43): MediaWiki\\Page\\WikiPageFactory->newFromTitle()
#1 /srv/mediawiki/workdir/includes/Rest/Handler/SearchHandler.php(253): MediaWiki\\Page\\RedirectStore->getRedirectTarget()
#2 /srv/mediawiki/workdir/includes/Rest/Handler/SearchHandler.php(222): MediaWiki\\Rest\\Handler\\SearchHandler->buildSinglePage()
#3 /srv/mediawiki/workdir/includes/Rest/Handler/SearchHandler.php(185): MediaWiki\\Rest\\Handler\\SearchHandler->buildPageObjects()
#4 /srv/mediawiki/workdir/includes/Rest/Handler/SearchHandler.php(368): MediaWiki\\Rest\\Handler\\SearchHandler->doSearch()
#5 /srv/mediawiki/workdir/includes/Rest/Router.php(414): MediaWiki\\Rest\\Handler\\SearchHandler->execute()
#6 /srv/mediawiki/workdir/includes/Rest/Router.php(338): MediaWiki\\Rest\\Router->executeHandler()
#7 /srv/mediawiki/workdir/includes/Rest/EntryPoint.php(167): MediaWiki\\Rest\\Router->execute()
#8 /srv/mediawiki/workdir/includes/Rest/EntryPoint.php(132): MediaWiki\\Rest\\EntryPoint->execute()
#9 /srv/mediawiki/workdir/rest.php(31): MediaWiki\\Rest\\EntryPoint::main()
#10 {main}

What should have happened instead?:

  • No fatal errors
  • Results displayed

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Latest MediaWiki as of now. Does not happen with a version from a week ago.

Observed in translatewiki.net canary testing during deployment.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Include Special pages in Search Resultsmediawiki/coremaster+115 -37
Add @throws annotation to getRedirectTarget()mediawiki/coremaster+1 -0
SearchHandler: skip search results which are no proper pagesmediawiki/coremaster+26 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Feb 9 2022, 1:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2022, 1:59 PM
Nikerabbit updated the task description. (Show Details)Feb 9 2022, 1:59 PM
Nikerabbit added a parent task: T300198: 1.38.0-wmf.22 deployment blockers.Feb 9 2022, 2:01 PM
Nikerabbit triaged this task as Unbreak Now! priority.Feb 9 2022, 2:03 PM
Nikerabbit added a project: MediaWiki-REST-API.

Erring on the side of caution, I am assuming this will happen next week's train for WMF production as well. Feel free to untag/adjust priority if this is not the case.

Nikerabbit updated the task description. (Show Details)Feb 9 2022, 2:08 PM
Zabe subscribed.Feb 9 2022, 2:17 PM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/753810.

Nikerabbit added subscribers: • Pchelolo, • nnikkhoui.Feb 9 2022, 2:20 PM
• Pchelolo assigned this task to • nnikkhoui.Feb 9 2022, 2:30 PM
Zabe added a comment.Feb 9 2022, 2:32 PM

I quickly threw together https://gerrit.wikimedia.org/r/c/mediawiki/core/+/761344, not sure if that is the correct fix.

abi_ subscribed.Feb 9 2022, 2:47 PM
gerritbot added a comment.Feb 9 2022, 3:06 PM

Change 761344 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] SearchHandler: skip search results which are no proper pages

https://gerrit.wikimedia.org/r/761344

gerritbot added a project: Patch-For-Review.Feb 9 2022, 3:06 PM
Jdlrobson renamed this task from Searching for special pages with new vector header: The given PageIdentity Special:AbuseFilter does not represent a proper page to Searching for special pages with REST API: The given PageIdentity Special:AbuseFilter does not represent a proper page.Feb 9 2022, 3:22 PM
Jdlrobson removed projects: Web-Team-Backlog-Archived, Vector (legacy skin).
gerritbot added a comment.Feb 9 2022, 3:27 PM

Change 761344 merged by jenkins-bot:

[mediawiki/core@master] SearchHandler: skip search results which are no proper pages

https://gerrit.wikimedia.org/r/761344

• nnikkhoui added a comment.Feb 9 2022, 3:43 PM

Thank you @Zabe for the patch - definitely a big miss on my end.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 9 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 9 2022, 4:10 PM
gerritbot added a comment.Feb 10 2022, 4:03 PM

Change 761659 had a related patch set uploaded (by Nikki Nikkhoui; author: Nikki Nikkhoui):

[mediawiki/core@master] Add @throws annotation to getRedirectTarget()

https://gerrit.wikimedia.org/r/761659

gerritbot added a project: Patch-For-Review.Feb 10 2022, 4:03 PM
gerritbot added a comment.Feb 10 2022, 5:13 PM

Change 761659 merged by jenkins-bot:

[mediawiki/core@master] Add @throws annotation to getRedirectTarget()

https://gerrit.wikimedia.org/r/761659

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2022, 6:10 PM
Nikerabbit added a comment.Feb 10 2022, 7:54 PM

FWIW we did do deployment to translatewiki.net and haven't seen issues. Feel free to adjust priority or close if nothing more needs to be done.

• nnikkhoui closed this task as Resolved.Feb 10 2022, 8:07 PM
Krinkle reopened this task as Open.EditedFeb 15 2022, 12:30 AM
Krinkle subscribed.

@Pchelolo I believe this change is fallout from change 753810 (for T296671).

I note that this seems very likely to end up not being needed after all (but Web team still deciding based on input at T296225#7635399 and T296671#7695667).

However, I believe your above change has interpreted the new fatal incorrectly. The problem was that special pages were making into the redirect modification code. The problem was not that special pages are in the results at all. If these were not genuine or useful pages to be found, they would presumably not be returned from the search backend in the first place.

As I understand, there has not been a feature request to remove Special pages from search engine backends, which it seems this change has caused by filtering them out after the fact, which I would consider a significant bug. I'm re-opening this as such.

Two good test cases:

1. Special page names.2. Special subpages
Screenshot 2022-02-15 at 00.29.19.png (464×551 px, 60 KB)
Screenshot 2022-02-15 at 00.29.28.png (191×576 px, 24 KB)
Krinkle lowered the priority of this task from Unbreak Now! to High.Feb 15 2022, 12:31 AM
Jdforrester-WMF removed a parent task: T300198: 1.38.0-wmf.22 deployment blockers.Feb 15 2022, 7:57 PM
Jdforrester-WMF subscribed.

Not UBN -> Not a blocker to the train.

Bugreporter added a parent task: T277363: New search widget API doesn't work in "Special:" and "File:" namespace.Feb 15 2022, 8:06 PM
gerritbot added a comment.Feb 15 2022, 8:57 PM

Change 762945 had a related patch set uploaded (by Nikki Nikkhoui; author: Nikki Nikkhoui):

[mediawiki/core@master] Include Special pages in Search Results

https://gerrit.wikimedia.org/r/762945

gerritbot added a project: Patch-For-Review.Feb 15 2022, 8:57 PM
• nnikkhoui added a comment.EditedFeb 22 2022, 2:22 PM

@Krinkle it looks to me like this endpoint has always been filtering out Special Pages from search results (see this older branch) but I'm wondering how you generated the screenshot, i might be misunderstanding the code that i linked

If we change the existing behavior, and actually include special pages, that would mean the schema would also have to change. As an example, (as i understand it) special pages won't ever have an id right? or do those typically come back with id:0 ?

• nnikkhoui mentioned this in T303352: Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $link: namespace must not be virtual.Mar 10 2022, 6:51 PM
taavi subscribed.Mar 15 2022, 1:32 PM
In T301346#7728182, @nnikkhoui wrote:

it looks to me like this endpoint has always been filtering out Special Pages from search results (see this older branch) but I'm wondering how you generated the screenshot, i might be misunderstanding the code that i linked

That screenshot is from the search widget used by all skins except new vector, which internally uses the Action API (api.php?action=opensearch).

gerritbot added a comment.Mar 16 2022, 4:38 PM

Change 771378 had a related patch set uploaded (by Nikki Nikkhoui; author: Nikki Nikkhoui):

[mediawiki/core@master] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core into review/nikki_nikkhoui/T301346

https://gerrit.wikimedia.org/r/771378

gerritbot added a comment.Mar 16 2022, 5:06 PM

Change 771378 abandoned by Nikki Nikkhoui:

[mediawiki/core@master] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core into review/nikki_nikkhoui/T301346

Reason:

https://gerrit.wikimedia.org/r/771378

• nnikkhoui added a comment.Mar 16 2022, 5:46 PM

@Majavah i followed up with @Krinkle on IRC and we cleared up my confusion, thanks!

abi_ unsubscribed.Mar 17 2022, 3:54 AM
gerritbot added a comment.Apr 9 2022, 3:11 PM

Change 762945 merged by jenkins-bot:

[mediawiki/core@master] Include Special pages in Search Results

https://gerrit.wikimedia.org/r/762945

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2022, 3:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 9 2022, 4:00 PM
• nnikkhoui closed this task as Resolved.Apr 25 2022, 3:51 PM

Should be fixed now!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits