Page MenuHomePhabricator
Create Task
Maniphest T301362

Limit story creation to logged in users
Closed, ResolvedPublic
Actions

Description

Pending final product decision.

This can be done by protecting the Story namespace and giving edit right to the user group.

Some permission checks have to be added to prevent showing create and edit links to anons.

We can configure the StoryBuilder special page so that it requires used to be logged in. If they are not, they will be redirected to the login page with a custom error message where we can explain why Wikistories is like that.

Details

SubjectRepoBranchLines +/-
Restrict story creation to logged in usersmediawiki/extensions/Wikistoriesmaster+14 -1
Restrict story creation to logged in usersmediawiki/extensions/Wikistoriesmaster+17 -2
Customize query in gerrit

Related Objects

Event Timeline

SBisson created this task.Feb 9 2022, 3:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2022, 3:10 PM
SBisson moved this task from Backlog to Definition on the Inuka-Team (Kanban) board.May 4 2022, 1:26 PM
SBisson renamed this task from Limit story creation to registered users to Limit story creation to logged in users.May 12 2022, 2:35 PM
SBisson updated the task description. (Show Details)May 12 2022, 3:45 PM
SBisson claimed this task.May 12 2022, 5:56 PM
SBisson triaged this task as Medium priority.
SBisson moved this task from Definition to Code Review on the Inuka-Team (Kanban) board.
gerritbot added a comment.May 12 2022, 5:56 PM

Change 791417 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Restrict story creation to logged in users

https://gerrit.wikimedia.org/r/791417

gerritbot added a project: Patch-For-Review.May 12 2022, 5:56 PM
gerritbot added a comment.May 16 2022, 8:15 PM

Change 791417 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Restrict story creation to logged in users

https://gerrit.wikimedia.org/r/791417

SBisson mentioned this in rEWSTc843a03e6d53: Restrict story creation to logged in users.May 16 2022, 8:15 PM
Maintenance_bot removed a project: Patch-For-Review.May 16 2022, 8:31 PM
SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.May 17 2022, 12:16 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 17 2022, 8:00 AM
SBisson moved this task from QA to Code Review on the Inuka-Team (Kanban) board.May 17 2022, 1:47 PM
gerritbot added a comment.May 17 2022, 1:47 PM

Change 792618 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Restrict story creation to logged in users

https://gerrit.wikimedia.org/r/792618

gerritbot added a project: Patch-For-Review.May 17 2022, 1:47 PM
gerritbot added a comment.May 19 2022, 5:50 PM

Change 792618 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Restrict story creation to logged in users

https://gerrit.wikimedia.org/r/792618

hueitan mentioned this in rEWSTbad103fea1eb: Restrict story creation to logged in users.May 19 2022, 5:50 PM
Maintenance_bot removed a project: Patch-For-Review.May 19 2022, 6:30 PM
SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.May 19 2022, 7:43 PM
• EUdoh-WMF subscribed.EditedMay 23 2022, 12:40 AM

Testing

  1. When not logged in, clicking on the CTA to create a wikistory prompts the user to log in.

image.png (856×686 px, 100 KB)

  1. Upon successfully logging in, the user is redirected to the image search screen.
  1. If the user creates an account, there is a link to continue to the image search screen.

image.png (698×1 px, 155 KB)

Nice work!

• EUdoh-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.May 23 2022, 12:41 AM
SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Jun 6 2022, 7:19 AM
SGautam_WMF closed this task as Resolved.Jun 6 2022, 7:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL