Page MenuHomePhabricator
Create Task
Maniphest T301401

Update DiscussionTools for warningbox changes
Closed, ResolvedPublic
Actions

Description

The changes in T300306 might require some changes in DiscussionTools. We have some CSS (added in T289354) that hides some duplicate warning boxes in the new topic tool.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update references to warningbox classmediawiki/extensions/DiscussionToolsmaster+1 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Feb 9 2022, 8:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2022, 8:16 PM
matmarex claimed this task.Feb 9 2022, 8:17 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.
matmarex added a parent task: T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release.
gerritbot added a comment.Feb 9 2022, 8:37 PM

Change 761462 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Update references to warningbox class

https://gerrit.wikimedia.org/r/761462

gerritbot added a project: Patch-For-Review.Feb 9 2022, 8:37 PM
matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Feb 9 2022, 8:39 PM
gerritbot added a comment.Feb 11 2022, 9:20 PM

Change 761462 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update references to warningbox class

https://gerrit.wikimedia.org/r/761462

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Feb 11 2022, 9:57 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.

QA steps: Re-check T289354 and T289354#7312789 and confirm that the messages don't appear in two places when using the new topic tool.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 11 2022, 10:00 PM
EAkinloose subscribed.Feb 14 2022, 2:17 PM

For T289354, the deletion log is shown once as expected. See

Screenshot 2022-02-14 at 15.14.03.png (1×3 px, 288 KB)

As well as T289354#7312789. See

Screenshot 2022-02-14 at 15.15.21.png (1×1 px, 189 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Feb 14 2022, 2:17 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Feb 18 2022, 3:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits