Page MenuHomePhabricator
Create Task
Maniphest T301412

Revert editquality isvc architecture to predictor-only
Closed, ResolvedPublic
Actions

Description

As discussed in T294419#7688032, the revscoring transformer architecture introduces a ton of overhead complexity that is unecessary at this point.

Let's revert back to the predictor-only design and move the feature extraction bit to either the predict method or even possibly the preprocess method (which might allow us to experiment with making the call async)

TODO:

  • Remove transformer code
  • Remove transformer blubber file & remove pipeline config
  • Remove transformer jobs from Jenkins (if necessary?)
  • Clear out registry for old images (unless we want to keep them around)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
editquality: fix double preprocess callmachinelearning/liftwing/inference-servicesmain+8 -4
editquality: remove transformer blubberfilemachinelearning/liftwing/inference-servicesmain+0 -114
ml-services: remove editquality transformeroperations/deployment-chartsmaster+0 -28
editquality: remove transformer codemachinelearning/liftwing/inference-servicesmain+30 -258
inference: remove editquality-transformer pipelineintegration/configmaster+0 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

• ACraze created this task.Feb 9 2022, 9:07 PM
Maintenance_bot added a project: artificial-intelligence.Feb 9 2022, 9:45 PM
kevinbazira claimed this task.Feb 10 2022, 10:31 AM
gerritbot added a comment.Feb 10 2022, 10:34 AM

Change 761589 had a related patch set uploaded (by Kevin Bazira; author: Kevin Bazira):

[machinelearning/liftwing/inference-services@main] editquality: remove transformer code

https://gerrit.wikimedia.org/r/761589

gerritbot added a project: Patch-For-Review.Feb 10 2022, 10:34 AM
gerritbot added a comment.Feb 10 2022, 11:32 AM

Change 761602 had a related patch set uploaded (by Kevin Bazira; author: Kevin Bazira):

[integration/config@master] inference: remove editquality-transformer pipeline

https://gerrit.wikimedia.org/r/761602

gerritbot added a comment.Feb 10 2022, 5:26 PM

Change 761602 merged by jenkins-bot:

[integration/config@master] inference: remove editquality-transformer pipeline

https://gerrit.wikimedia.org/r/761602

gerritbot added a comment.Feb 10 2022, 5:49 PM

Change 761589 merged by jenkins-bot:

[machinelearning/liftwing/inference-services@main] editquality: remove transformer code

https://gerrit.wikimedia.org/r/761589

kevinbazira mentioned this in rMLIS33fabfb0eafb: editquality: remove transformer code.Feb 10 2022, 5:49 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2022, 6:10 PM
gerritbot added a comment.Feb 11 2022, 5:26 AM

Change 761788 had a related patch set uploaded (by Kevin Bazira; author: Kevin Bazira):

[machinelearning/liftwing/inference-services@main] editquality: remove transformer blubberfile

https://gerrit.wikimedia.org/r/761788

gerritbot added a project: Patch-For-Review.Feb 11 2022, 5:26 AM
gerritbot added a comment.Feb 11 2022, 8:39 AM

Change 761877 had a related patch set uploaded (by Kevin Bazira; author: Kevin Bazira):

[operations/deployment-charts@master] ml-services: remove editquality transformer

https://gerrit.wikimedia.org/r/761877

gerritbot added a comment.Feb 11 2022, 9:13 AM

Change 761877 merged by Elukey:

[operations/deployment-charts@master] ml-services: remove editquality transformer

https://gerrit.wikimedia.org/r/761877

elukey added a comment.Feb 14 2022, 10:01 AM
elukey@deneb:~$ docker-registryctl delete-tags docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer
We're about to delete the following tags for image docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer:
2022-01-27-181501-publish
2022-01-28-184645-publish
2022-01-31-173323-publish
2022-02-02-170500-publish
2022-02-02-174851-publish
stable
Ok to proceed? (y/n)y
docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer:2022-01-27-181501-publish[DONE]
docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer:2022-01-28-184645-publish[DONE]
docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer:2022-01-31-173323-publish[DONE]
docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer:2022-02-02-170500-publish[DONE]
docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer:2022-02-02-174851-publish[DONE]
docker-registry.wikimedia.org/wikimedia/machinelearning-liftwing-inference-services-editquality-transformer:stable[GONE]
gerritbot added a comment.Feb 14 2022, 10:11 AM

Change 762410 had a related patch set uploaded (by Elukey; author: Elukey):

[operations/puppet@production] profile::kubernetes::node: add grub settings for Bullseye

https://gerrit.wikimedia.org/r/762410

gerritbot added a comment.Feb 14 2022, 4:27 PM

Change 761788 merged by Accraze:

[machinelearning/liftwing/inference-services@main] editquality: remove transformer blubberfile

https://gerrit.wikimedia.org/r/761788

kevinbazira mentioned this in rMLIS86dc11ff7f79: editquality: remove transformer blubberfile.Feb 14 2022, 4:30 PM
• ACraze updated the task description. (Show Details)Feb 14 2022, 4:32 PM
• ACraze moved this task from Parked to In Progress on the Machine-Learning-Team (Active Tasks) board.Feb 14 2022, 4:40 PM
calbon closed this task as Resolved.Feb 14 2022, 6:14 PM
calbon moved this task from In Progress to Completed on the Machine-Learning-Team (Active Tasks) board.
gerritbot added a comment.Feb 15 2022, 7:37 PM

Change 762937 had a related patch set uploaded (by Accraze; author: Accraze):

[machinelearning/liftwing/inference-services@main] editquality: fix double preprocess call

https://gerrit.wikimedia.org/r/762937

gerritbot added a comment.Feb 16 2022, 4:35 PM

Change 762937 merged by jenkins-bot:

[machinelearning/liftwing/inference-services@main] editquality: fix double preprocess call

https://gerrit.wikimedia.org/r/762937

• ACraze mentioned this in rMLISc839c6a7d54e: editquality: fix double preprocess call.Feb 16 2022, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits