Page MenuHomePhabricator
Create Task
Maniphest T301485

PHP Warning: geoip_country_code_by_name(): Required database not available at /usr/share/GeoIP/GeoIP.dat.
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: geoip_country_code_by_name(): Required database not available at /usr/share/GeoIP/GeoIP.dat.
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.21/extensions/FundraiserLandingPage/includes/specials/FundraiserRedirector.php(41)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.21/extensions/FundraiserLandingPage/includes/specials/FundraiserRedirector.php(41): geoip_country_code_by_name(string)
#2 /srv/mediawiki/php-1.38.0-wmf.21/includes/specialpage/SpecialPage.php(671): FundraiserRedirector->execute(NULL)
#3 /srv/mediawiki/php-1.38.0-wmf.21/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(NULL)
#4 /srv/mediawiki/php-1.38.0-wmf.21/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#5 /srv/mediawiki/php-1.38.0-wmf.21/includes/MediaWiki.php(903): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.38.0-wmf.21/includes/MediaWiki.php(563): MediaWiki->main()
#7 /srv/mediawiki/php-1.38.0-wmf.21/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.38.0-wmf.21/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}
Notes
  • Exclusively happening on dontate wiki
  • Roughly happening twice an hour
  • Looks new with wmf.21

Details

MediaWiki Version
1.38.0-wmf.21
Request URL
https://donate.wikimedia.org/wiki/Special:FundraiserRedirector?rdfrom=*
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Stop falling back to server-side GeoIP lookupEjeggmediawiki/extensions/FundraiserLandingPagemaster+0 -9
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Feb 10 2022, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2022, 4:28 PM
Dwisehaupt added a project: Fundraising-Backlog.Feb 10 2022, 5:22 PM
• DStrine added subscribers: Pcoombe, • DStrine.Feb 10 2022, 6:14 PM

+ @Pcoombe as fyi. I'm discussing this with fr-tech in IRC.

• DStrine triaged this task as High priority.Feb 10 2022, 6:16 PM
• DStrine lowered the priority of this task from High to Medium.
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.
• DStrine added a subscriber: fundraising Sprint Black Hole Fillings.
• DStrine removed a subscriber: fundraising Sprint Black Hole Fillings.
Krinkle moved this task from Untriaged to Feb 2022 on the Wikimedia-production-error board.Feb 13 2022, 2:35 PM
Jgreen removed a project: fundraising-tech-ops.Feb 14 2022, 2:27 PM
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Feb 15 2022, 8:39 PM
• DStrine added a project: Fundraising Sprint Cheese String Theory.Feb 15 2022, 8:50 PM
Ejegg subscribed.Feb 15 2022, 9:20 PM

@Pcoombe mentioned in IRC that this is only happening a couple of times an hour, and that he got correctly geolocated (I assume by the varnish server?) when visiting donatewiki in incognito mode.

So this isn't a big donor impact, but we should stop throwing production errors. Maybe add a try/catch or just remove the php-side geolocation altogether.

Pcoombe added a comment.Feb 16 2022, 11:50 AM

@Ejegg I don't know anything about how often it's happening (although twice per hour was in the task description) but can confirm I haven't been able to reproduce when visiting donatewiki in Incognito

• DStrine added a project: Fundraising Sprint Discworld reformatted as ntfs.Mar 1 2022, 9:10 PM
gerritbot added a comment.Mar 11 2022, 2:49 AM

Change 769817 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/FundraiserLandingPage@master] Stop falling back to server-side GeoIP lookup

https://gerrit.wikimedia.org/r/769817

gerritbot added a project: Patch-For-Review.Mar 11 2022, 2:49 AM
Ejegg added a comment.Mar 11 2022, 2:56 AM

Huh, seems not to be happening any more:

https://logstash.wikimedia.org/app/dashboards#/view/AXFV7JE83bOlOASGccsT?_g=(filters%3A!()%2CrefreshInterval%3A(pause%3A!t%2Cvalue%3A0)%2Ctime%3A(from%3Anow-2M%2Cto%3Anow))

and seems to have only happened 8 times in history. Maybe not worth worrying about right now.

gerritbot added a comment.Mar 11 2022, 2:57 AM

Change 769817 abandoned by Ejegg:

[mediawiki/extensions/FundraiserLandingPage@master] Stop falling back to server-side GeoIP lookup

Reason:

Seems like a very rare issue

https://gerrit.wikimedia.org/r/769817

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2022, 3:10 AM
• DStrine removed a project: Fundraising Sprint Discworld reformatted as ntfs.Mar 14 2022, 8:03 PM
• DStrine moved this task from Current Sprint to FY 2022-2023 on the Fundraising-Backlog board.
gerritbot added a comment.Mar 14 2022, 8:05 PM

Change 769817 restored by Ejegg:

[mediawiki/extensions/FundraiserLandingPage@master] Stop falling back to server-side GeoIP lookup

https://gerrit.wikimedia.org/r/769817

gerritbot added a project: Patch-For-Review.Mar 14 2022, 8:05 PM
Ejegg added a project: Fundraising Sprint Discworld reformatted as ntfs.Mar 14 2022, 8:09 PM
Ejegg moved this task from FY 2022-2023 to Current Sprint on the Fundraising-Backlog board.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Discworld reformatted as ntfs board.
• DStrine added a project: Fundraising Sprint e^🥧👀=yum.Mar 15 2022, 8:33 PM
AnnWF moved this task from Backlog to Review on the Fundraising Sprint e^🥧👀=yum board.Mar 16 2022, 4:25 PM
AnnWF moved this task from Review to Pending Deployment on the Fundraising Sprint e^🥧👀=yum board.Mar 21 2022, 9:52 PM
gerritbot added a comment.Mar 21 2022, 9:58 PM

Change 769817 merged by jenkins-bot:

[mediawiki/extensions/FundraiserLandingPage@master] Stop falling back to server-side GeoIP lookup

https://gerrit.wikimedia.org/r/769817

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.3; 2022-03-22).Mar 21 2022, 11:00 PM
• DStrine closed this task as Resolved.Mar 29 2022, 7:21 PM
• DStrine moved this task from Pending Deployment to Done on the Fundraising Sprint e^🥧👀=yum board.
• DStrine set the point value for this task to 2.
Ejegg mentioned this in T352247: Remove calls to GeoIP 1 in Extension:LandingCheck.Dec 6 2023, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits