Page MenuHomePhabricator
Create Task
Maniphest T301520

Drop our dependency on Vue Router so we can migrate to Vue3 more easily
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Follow-up 12b55153: Actually delete vue-routermediawiki/extensions/WikiLambdamaster+0 -3 K
Add cleanup task for vue router removalmediawiki/extensions/WikiLambdamaster+69 -24
Remove vue-router from applicationmediawiki/extensions/WikiLambdamaster+637 -281
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 10 2022, 10:24 PM
Jdforrester-WMF added a parent task: T270783: Migrate WikiLambda Vue code to Vue3.Feb 18 2022, 11:25 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Feb 22 2022, 5:26 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Feb 22 2022, 5:37 PM
SimoneThisDot changed the task status from Open to In Progress.Mar 2 2022, 12:41 PM
SimoneThisDot changed the task status from In Progress to Open.
SimoneThisDot changed the task status from Open to In Progress.
SimoneThisDot claimed this task.
SimoneThisDot moved this task from Ready to do to In progress on the Abstract Wikipedia team (Phase η – Generic types) board.
gerritbot added a comment.Mar 2 2022, 12:49 PM

Change 767497 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] [WIP] Remove vue-router from application

https://gerrit.wikimedia.org/r/767497

gerritbot added a project: Patch-For-Review.Mar 2 2022, 12:49 PM
DVrandecic moved this task from In progress to Code Review on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 8 2022, 5:47 PM
gerritbot added a comment.Mar 9 2022, 1:50 PM

Change 767497 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove vue-router from application

https://gerrit.wikimedia.org/r/767497

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 9 2022, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 9 2022, 2:10 PM
Jdforrester-WMF moved this task from Code Review to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Mar 9 2022, 6:38 PM
gerritbot added a comment.Mar 16 2022, 12:09 AM

Change 771088 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Add cleanup task for vue router removal

https://gerrit.wikimedia.org/r/771088

gerritbot added a project: Patch-For-Review.Mar 16 2022, 12:09 AM
gerritbot added a comment.Mar 17 2022, 2:00 PM

Change 771088 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add cleanup task for vue router removal

https://gerrit.wikimedia.org/r/771088

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2022, 2:10 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 17 2022, 3:00 PM
DVrandecic closed this task as Resolved.Mar 22 2022, 4:32 PM
SBisson added a subscriber: SBisson.Mar 31 2022, 3:54 PM

Hi, the Wikistories extension is also using vue-router. Could you share in a nutshell how removing the router with help with the migration to vue3 so we can assess our situation? Thanks!

Jdforrester-WMF added a comment.Mar 31 2022, 8:55 PM
In T301520#7822200, @SBisson wrote:

Hi, the Wikistories extension is also using vue-router. Could you share in a nutshell how removing the router with help with the migration to vue3 so we can assess our situation? Thanks!

At the time of working on the Vue2->3 test port, the only version of vue-router that was Vue3-compatible was an alpha badged as incomplete. Given that we weren't using it much, DST had said that we shouldn't use it, and that we would have had to take it through a security review to use in production, we decided it was a lot simpler and easier just to bin it. I believe that there's now a proper Vue3 version out there now, but the other things hold still, so…

SBisson added a comment.Apr 1 2022, 2:03 PM

Thanks @Jdforrester-WMF. There is indeed a stable router for Vue3 now but getting it reviewed and accepted is another hurdle we don't need at the moment. Our usage is also minimal so we'll look at your replacement solution for inspiration. There may be an opportunity for a vue-compatible micro router in core if T290916 doesn't get any traction.

gerritbot added a comment.May 16 2022, 5:06 PM

Change 792258 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Follow-up 12b55153: Actually delete vue-router

https://gerrit.wikimedia.org/r/792258

gerritbot added a project: Patch-For-Review.May 16 2022, 5:06 PM
gerritbot added a comment.May 19 2022, 2:51 AM

Change 792258 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Follow-up 12b55153: Actually delete vue-router

https://gerrit.wikimedia.org/r/792258

matmarex mentioned this in T290916: Consider providing Vue Router in MW for use by Vue-using MW extensions/skins.Jun 16 2023, 8:46 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 16 2023, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL