Update Cucumber to new version
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Osamaahmed17
	Feb 11 2022, 12:16 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Osamaahmed17

zeljkofilipin

Description

The current version of Cucumber has been expired and now it requires an update in the following files in the CirrusSearch extension.

page_step.js
search_step.js
hook.js
world.js

It requires to uninstall of current cucumber and then npm install --save-dev @cucumber/cucumber. After that, it requires packages to be loaded as @cucumber/cucumber instead of cucumber. More information can be found at P20601.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	cucumber: Update cucumber to latest version	mediawiki/extensions/CirrusSearch	master	+452 -132

Customize query in gerrit

Related Objects

Mentioned Here: P21485 (An Untitled Masterwork)
P20601 NPM run test failing for CirriusSearch

Event Timeline

Osamaahmed17 created this task.Feb 11 2022, 12:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2022, 12:16 PM

Osamaahmed17 updated the task description. (Show Details)Feb 11 2022, 12:18 PM

Osamaahmed17 added a project: CirrusSearch.Feb 11 2022, 12:24 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptFeb 11 2022, 12:24 PM

Change 761907 had a related patch set uploaded (by Osamaahmed17; author: Osamaahmed17):

[mediawiki/extensions/CirrusSearch@master] cucumber: Update cucumber to latest version

https://gerrit.wikimedia.org/r/761907

gerritbot added a project: Patch-For-Review.Feb 11 2022, 12:30 PM

zeljkofilipin triaged this task as Medium priority.Feb 11 2022, 12:45 PM

zeljkofilipin added a project: User-zeljkofilipin.

zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.

• MPhamWMF moved this task from needs triage to watching / waiting on the Discovery-Search board.Feb 17 2022, 11:13 PM

zeljkofilipin updated the task description. (Show Details)Feb 24 2022, 2:37 PM

I can't reproduce the problem on my machine. The paste (P20601) does not say which branch you're using. I've tried running npm t on master and it works just fine. Does npm t fail for a commit in gerrit?

P21485 (An Untitled Masterwork)

1	nobody@docker-desktop:/CirrusSearch$ git branch
2	* master
3
4	nobody@docker-desktop:/CirrusSearch$ node -v
5	v12.22.5
6
7	nobody@docker-desktop:/CirrusSearch$ npm -v
8	7.21.0
9
10	nobody@docker-desktop:/CirrusSearch$ npm ci
11	...
12
13	nobody@docker-desktop:/CirrusSearch$ npm t
14
15	> cirrussearch@0.0.0 test
16	> grunt test
17
18	Running "eslint:all" (eslint) task
19	Browserslist: caniuse-lite is outdated. Please run:
20	npx browserslist@latest --update-db
21
22	Why you should do it regularly:
23	https://github.com/browserslist/browserslist#browsers-data-updating
24
25	/CirrusSearch/tests/phpunit/fixtures/configDump/enwiki_crosslang_frwiki_config.json
26	0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
27
28	/CirrusSearch/tests/phpunit/fixtures/configDump/enwiki_crosslang_frwiki_invalid_config.json
29	0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
30
31	/CirrusSearch/tests/phpunit/fixtures/configDump/enwiki_sisterproject_configs.json
32	0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
33
34	/CirrusSearch/tests/phpunit/fixtures/regexParser/ref_impl_fixtures.json
35	0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override
36
37	✖ 4 problems (0 errors, 4 warnings)
38
39	Running "banana:all" (banana) task
40	>> 2 message directories checked.
41
42	Running "stylelint:all" (stylelint) task
43	>> Linted 1 files without errors
44
45	Done.